Closed Bug 1102986 Opened 10 years ago Closed 9 years ago

[Gecko][Camera] Align camera preview media stream behaviour with other streams

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

Attachments

(1 file, 1 obsolete file)

Refactoring of video media streams found in bug 879717 will break the camera preview. This is because the camera preview media stream does not do everything that media streams normally do (such as create a video track).

The salient behaviours are as follows:
1) Create a video track, required to start playback
2) Set the hints to indicate this stream supports video, required throughout media code to know what tracks it should expect
3) Initial preview stream with input stream using helper function, ensures listeners are setup properly to capture events like track creation
4) Add test case to ensure our preview stream can be stopped and restarted
Patch taken from bug 879717 and carries r=roc.
Attachment #8526840 - Flags: review+
Blocks: 879717
Status: NEW → ASSIGNED
Get building again, make some non-functional changes to simplify (originally was starting / ending tracks, but only starting is necessary).
Attachment #8526840 - Attachment is obsolete: true
Assignee: nobody → aosmond
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fc5ea5a66624
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.