1103006 - Update start.mozilla.org from https://github.com/mozilla/fx36start

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Product Delivery, task)

Description

[Jonathan Petto [:jpetto]]

Another update to start.mozilla.org - this time providing different modal messaging based on browser version.

Can we push to stage for testing?

Thanks!

Comment 1

[Chris Turra [:cturra]]

push to stage complete. please let me know when you want this change going to prod.

Comment 2

[Jonathan Petto [:jpetto]]

Attachment: odd-strings.png

:cturra - We're seeing some odd strings come up on stage (see attached). Those strings (e.g. "# Displayed to users with Firefox 3") aren't anywhere in the code base that I can see. It looks like maybe that's meant to be a Python comment or something?

I don't get this behavior locally. Any ideas?

Comment 3

[Francesco Lodolo [:flod]]

Interesting, those are comments that I added to the .lang file.

How old is the parser on that project?
https://github.com/mozilla/fx36start/blob/master/vendor/dotlang/extract.py

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #3)
> Interesting, those are comments that I added to the .lang file.

http://viewvc.svn.mozilla.org/vc/projects/l10n-misc/trunk/fx36start/locale/en-US/fx36start.lang?revision=135334&view=markup

Comment 5

[Francesco Lodolo [:flod]]

Compare current parser
https://github.com/mozilla/fx36start/blob/master/vendor/dotlang/translate.py#L32-L38

To what we use on bedrock
https://github.com/mozilla/fx36start/blob/master/vendor/dotlang/translate.py#L32-L38

Let me know if you prefer me to remove the comments instead.

Comment 6

[Paul [:pmac] McLanahan]

(In reply to Francesco Lodolo [:flod] from comment #4)
> (In reply to Francesco Lodolo [:flod] from comment #3)
> > Interesting, those are comments that I added to the .lang file.
> 
> http://viewvc.svn.mozilla.org/vc/projects/l10n-misc/trunk/fx36start/locale/
> en-US/fx36start.lang?revision=135334&view=markup

Looks like the .lang parser is pretty basic. I can add support for ignoring comments pretty quickly though.

Comment 7

[Paul [:pmac] McLanahan]

Attachment: Link to Github pull-request: https://github.com/mozilla/fx36start/pull/13

PR to fix lang file comments issue.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/fx36start

https://github.com/mozilla/fx36start/commit/070dc149a67ad179b0adb1730f558fd6f2f4066f
Bug 1103006: Skip lang file comments.

https://github.com/mozilla/fx36start/commit/d984507ba2b85e8712a4b047a402909ca21fecb8
Merge pull request #13 from pmclanahan/master

Bug 1103006: Skip lang file comments.

Comment 9

[Jonathan Petto [:jpetto]]

:cturra - Can we get another push to the staging server? The merge above should fix the odd strings we were seeing.

Thanks!

Comment 10

[Chris Turra [:cturra]]

(In reply to Jon Petto [:jpetto] from comment #9)
> :cturra - Can we get another push to the staging server? The merge above
> should fix the odd strings we were seeing.

i have re-pushed to stage as requested.

Comment 11

[Jonathan Petto [:jpetto]]

Looking good. Thanks :cturra & :pmac!

:garethc - Can you give the page a test?

http://start.allizom.org/en-US/

Comment 12

[Gareth Cull [:garethc]]

The 3 variations look good to me Jon. Thanks!

Comment 13

[Jonathan Petto [:jpetto]]

:cturra - Looks like we're good to go. Can you do a production push? Thanks!

Comment 14

[Jonathan Petto [:jpetto]]

As we're still waiting for some major locales to be localized, let's hold off on the production push until Monday.

:cturra - Can we plan a production push for 12/1?

Comment 15

[Chris Turra [:cturra]]

(In reply to Jon Petto [:jpetto] from comment #14)
> As we're still waiting for some major locales to be localized, let's hold
> off on the production push until Monday.
> 
> :cturra - Can we plan a production push for 12/1?

sure. i can hold on the production push until 12/1 as requested.

Comment 16

[Jonathan Petto [:jpetto]]

:cturra - Could we get a production push today? (Sorry for the double needinfo...)

Comment 17

[Chris Turra [:cturra]]

sorry for not pushing this to prod last week. i missed the needsinfo ping due to the work week and infra was in a change freeze for the week. 

this has now been sent to prod as requested.

Comment 18

[Chris More [:cmore]]

Looks good. Thanks!