1103037 - The $changes hash returned by different update methods should not combine multiple added/remove values using a comma

Status: NEW

(Bugzilla :: WebService, enhancement)

Description

[David Lawrence [:dkl]]

This stemmed from an issue I found with webservice calls to update, etc. but this is can be useful in more than the webservices.

Currently Object->update returns a $changes hash that has the field names, and then a two item list for added and removed values. Object.pm mainly works with single value fields so not an issue.

Bug->update calls Object->update and then does some other updates on it's own for special fields that can have multiple values. It adds the fields and their added/removed values to the $changes hash. For fields that can have one or more values, it combines added/removed using comma delimiter. 

Instead of doing a comma delimited string in Bug->update $changes for multi values, it should just attach a list for added and a list for removed. 

Then then templates can do the joining using a comma when displaying the changes. The webservices API can ten return the list instead as well. This works well if one of the values has a comma itself and so breaking the string on commas would not work in that case. 

dkl