Closed Bug 1103056 Opened 10 years ago Closed 9 years ago

Make optimized asm.js FFI exit also work with Baseline scripts

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Odin has optimized paths for calls to Ion-compiled functions. It's pretty straight-forward to make this code work with Baseline as well; we just have to move the linked list from IonScript to BaselineScript and modify TryEnablingIon.

This should make FFI calls more robust and predictable: Baseline can compile all scripts and scripts are not invalidated on type changes etc.

This patch also renames various things from Ion to Jit.
Attachment #8526900 - Flags: review?(luke)
Attachment #8526900 - Flags: review?(hv1989)
(In reply to Jan de Mooij [:jandem] from comment #0)
> we just have to move the linked list from IonScript to BaselineScript

Er, the Vector.
Summary: Make asm.js FFI exits also work with Baseline scripts → Make optimized asm.js FFI exit also work with Baseline scripts
Comment on attachment 8526900 [details] [diff] [review]
Patch

Review of attachment 8526900 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!
Attachment #8526900 - Flags: review?(luke) → review+
Comment on attachment 8526900 [details] [diff] [review]
Patch

Review of attachment 8526900 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent!
Attachment #8526900 - Flags: review?(hv1989) → review+
https://hg.mozilla.org/mozilla-central/rev/9d885b102911
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.