need to not show "manage search engines" dropdown on about:home/about:newtab if browser.search.showOneOffButtons is false

VERIFIED FIXED

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Gavin, Assigned: mossop)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox34+ verified, firefox35+ unaffected, firefox36 unaffected)

Details

Attachments

(1 attachment)

The search settings pane doesn't exist if that pref is false (i.e. for all non-en-US users), and so the menu item is not useful.
Assignee: nobody → dtownsend+bugmail
Posted patch patchSplinter Review
Attachment #8527007 - Flags: review?(felipc)
Attachment #8527007 - Flags: review?(felipc) → review+
[Tracking Requested - why for this release]:

Apparently we need this on aurora too
Attachment #8527007 - Flags: approval-mozilla-beta+
Can you nom for aurora uplift?  We merge on Friday.
Flags: needinfo?(dtownsend+bugmail)
Flags: qe-verify+
QA Contact: petruta.rasa
Verified using Firefox 34.0 RC build (20141124205320) under Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OSX 10.9.5 that when the pref is set to false, the old UI is back in place.
This bug was a workaround in case we had to go with the new about:home search UI for all users (as opposed to only the users who got the new Flare UI in the searchbar).
But we managed to make the UI switchable on time (based on browser.search.showOneOffButtons pref), and for central/aurora (36/35), we are landing the new patch right away, so this problem doesn't apply there.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(dtownsend+bugmail)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.