Closed Bug 1103179 Opened 10 years ago Closed 9 years ago

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/content-tabs/test-install-xpi.js | test-install-xpi.js::test_xpinstall_actually_install

Categories

(Thunderbird :: Testing Infrastructure, defect)

Product:
Thunderbird
Component:
Testing Infrastructure
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 45.0

People

(Reporter: hiro, Assigned: aceman)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

siteRegExp not defined in test-install-xpi [checked in]
1.72 KB, patch
aceman
: review+
Details | Diff | Splinter Review
increase timeouts [checked in]
4.00 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review 
TEST-START | /builds/slave/test/build/mozmill/content-tabs/test-install-xpi.js | test_xpinstall_actually_install
Step Pass: {"function": "controller.click()"}
[2197] WARNING: We should have hit the document element...: file /builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/layout/xul/BoxObject.cpp, line 183
Step Pass: {"function": "controller.waitFor()"}
Step Pass: {"function": "controller.click()"}
++DOCSHELL 0x7f19d2984000 == 16 [pid = 2197] [id = 46]
++DOMWINDOW == 31 (0x7f19d009b400) [pid = 2197] [serial = 145] [outer = (nil)]
++DOMWINDOW == 32 (0x7f19d0eb0800) [pid = 2197] [serial = 146] [outer = 0x7f19d009b400]
--DOCSHELL 0x7f19d2507000 == 15 [pid = 2197] [id = 45]
--DOMWINDOW == 31 (0x7f19c3f14c00) [pid = 2197] [serial = 143] [outer = (nil)] [url = chrome://mozapps/content/xpinstall/xpinstallConfirm.xul]
--DOCSHELL 0x7f19d2984000 == 14 [pid = 2197] [id = 46]
--DOMWINDOW == 30 (0x7f19c68abc00) [pid = 2197] [serial = 144] [outer = (nil)] [url = about:blank]
Test Failure: Timeout waiting for alert
Keywords: intermittent-failure
The failing tests in that file produce:
JavaScript error: chrome://messenger/content/messenger.xul, line 1: ReferenceError: siteRegExp is not defined

The failures are intermittent and I only see them on Win XP on the trunk server. The other platforms also produce these errors (in the log) but somehow it does not make the tests fail.

15:02:01  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_install_corrupt_xpi
15:02:01     INFO -  TEST-START | C:\slave\test\build\tests\mozmill\content-tabs\test-install-xpi.js | test_install_xpi_offer
15:02:01     INFO -  JavaScript error: chrome://messenger/content/messenger.xul, line 1: ReferenceError: siteRegExp is not defined
15:02:02     INFO -  1443391322683	addons.xpi	WARN	Download of http://localhost:43336/content-tabs/corrupt.xpi failed: Error: Illegal add-on ID installxpitest (resource://gre/modules/addons/XPIProvider.jsm:1019:1) JS Stack trace: loadManifestFromRDF@XPIProvider.jsm:1019:1 < loadFromRDF@XPIProvider.jsm:1261:17 < loadManifestFromZipReader@XPIProvider.jsm:1290:17 < TaskImpl_run@Task.jsm:314:40 < TaskImpl@Task.jsm:275:3 < createAsyncFunction/asyncFunction@Task.jsm:249:14 < AI_loadManifest@XPIProvider.jsm:5095:26 < TaskImpl_run@Task.jsm:314:40 < TaskImpl@Task.jsm:275:3 < createAsyncFunction/asyncFunction@Task.jsm:249:14 < AI_onStopRequest@XPIProvider.jsm:5404:9 < waitFor@utils.js:478:5 < WindowWatcher_waitForModalDialog@test-window-helpers.js:377:1 < wait_for_modal_dialog@test-window-helpers.js:614:3 < test_install_xpi_offer@test-install-xpi.js:125:3 < Runner.prototype.wrapper@frame.js:585:9 < Runner.prototype._runTestModule@frame.js:655:9 < Runner.prototype.runTestModule@frame.js:701:3 < Runner.prototype.runTestDirectory@frame.js:525:7 < runTestDirectory@frame.js:707:3 < Bridge.prototype._execFunction@server.js:179:10 < Bridge.prototype.execFunction@server.js:183:16 < @server.js:283:1 < Session.prototype.receive@server.js:283:3 < AsyncRead.prototype.onDataAvailable@server.js:88:3
15:02:02     INFO -  [3312] WARNING: We should have hit the document element...: file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/layout/xul/BoxObject.cpp, line 183
15:02:13  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_install_xpi_offer
15:02:13     INFO -  TEST-START | C:\slave\test\build\tests\mozmill\content-tabs\test-install-xpi.js | test_xpinstall_disabled
15:02:13     INFO -  JavaScript error: chrome://messenger/content/messenger.xul, line 1: ReferenceError: siteRegExp is not defined
15:02:13     INFO -  JavaScript error: resource://mozmill/modules/frame.js -> file:///C:/slave/test/build/tests/mozmill/shared-modules/test-window-helpers.js, line 364: Error: Timeout while waiting for modal dialog.
15:02:13  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_xpinstall_disabled
15:02:13     INFO -  TEST-START | C:\slave\test\build\tests\mozmill\content-tabs\test-install-xpi.js | test_xpinstall_actually_install
15:02:13     INFO -  JavaScript error: chrome://messenger/content/messenger.xul, line 1: ReferenceError: siteRegExp is not defined
15:02:24  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_xpinstall_actually_install
The variable is defined at http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/content-tabs/test-install-xpi.js#22

21 var url = collector.addHttpResource('../content-tabs/html', 'content-tabs');
22 var siteRegExp = new RegExp("^" + url);

And is only used here:

89 function test_setup() {
90   gNewTab =
91     open_content_tab_with_url(url + "installxpi.html",
92                               "specialTabs.siteClickHandler(event, siteRegExp);");

I wonder if the variable (defined in the test file) is accessible from the layers of the callbacks in tbas where this code is sent.
Flags: needinfo?(mkmelin+mozilla)
No, it's not accessible, and from a quick look looks useless too.
Flags: needinfo?(mkmelin+mozilla)
Component: General → Testing Infrastructure
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8693119 [details] [diff] [review]
siteRegExp not defined in test-install-xpi [checked in]

Review of attachment 8693119 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, the error message is no more and the test run has cleaner output (comparing Win XP before and after on try-server).
Thanks.
Attachment #8693119 - Flags: review?(acelists) → review+
Sadly this did not fix the failure.
Assignee: aleth → nobody
Status: ASSIGNED → NEW
It seems the only failing test now is test-install-xpi.js::test_install_xpi_offer not test_xpinstall_actually_install as in the bug summary.

And the error is:
05:16:23     INFO -    EXCEPTION: Timeout waiting for modal dialog to open.
05:16:23     INFO -      at: utils.js line 447
05:16:23     INFO -         TimeoutError utils.js:447 13
05:16:23     INFO -         waitFor utils.js:485 1
05:16:23     INFO -         WindowWatcher_waitForModalDialog test-window-helpers.js:377 1
05:16:23     INFO -         wait_for_modal_dialog test-window-helpers.js:614 3
05:16:23     INFO -         test_install_xpi_offer test-install-xpi.js:124 3
05:16:23     INFO -         Runner.prototype.wrapper frame.js:585 9
05:16:23     INFO -         Runner.prototype._runTestModule frame.js:655 9
05:16:23     INFO -         Runner.prototype.runTestModule frame.js:701 3
05:16:23     INFO -         Runner.prototype.runTestDirectory frame.js:525 7
05:16:23     INFO -         runTestDirectory frame.js:707 3
05:16:23     INFO -         Bridge.prototype._execFunction server.js:179 10
05:16:23     INFO -         Bridge.prototype.execFunction server.js:183 16
05:16:23     INFO -         Session.prototype.receive server.js:283 3
05:16:23     INFO -         AsyncRead.prototype.onDataAvailable server.js:88 3
Eh, on Win 7 it still is test_xpinstall_actually_install .
I increased the timeouts in the test and the results are promising: 
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9419ef874145
Attachment #8696236 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8696236 [details] [diff] [review]
increase timeouts [checked in]

Review of attachment 8696236 [details] [diff] [review]:
-----------------------------------------------------------------

Lets try it.
Attachment #8696236 - Flags: review?(mkmelin+mozilla) → review+
Attachment #8693119 - Attachment description: siteRegExp not defined in test-install-xpi → siteRegExp not defined in test-install-xpi [checked in]
Attachment #8696236 - Attachment description: 1103179.patch → increase timeouts [checked in]
Assignee: nobody → acelists
Looks good!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: