1103272 - aws_stop_idle.py should use ssh keys for authenication

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Comment 1

[Rail Aliiev [:rail]]

Attachment: stop_idle_ssh_key-puppet.diff

Comment 2

[Rail Aliiev [:rail]]

Attachment: stop_idle_ssh_key2-puppet.diff

To be landed after the first one is live and when the corresponding cloud-tools changes are landed.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8527382 [details] [diff] [review]
stop_idle_ssh_key-puppet.diff

Review of attachment 8527382 [details] [diff] [review]:
-----------------------------------------------------------------

r+ otherwise

::: modules/toplevel/manifests/slave/releng.pp
@@ +28,5 @@
>          include packages::mapi_headers
>          include fw::windows_exceptions
>          include fw::windows_settings
>      }
> +    if ($::virtual =~ /xen/) {

Don't we have a better fact for this now?

Comment 4

[Rail Aliiev [:rail]]

I tried to use $::ec2_instance_id in http://hg.mozilla.org/build/puppet/rev/60703a9e891e#l4.12 and it didn't work (the condition was true in any case). Maybe I should have compared it with "", not with null...

Comment 5

[Rail Aliiev [:rail]]

https://docs.puppetlabs.com/learning/variables.html#aside-beware-of-the-fake-false says "all facts are strings", so the following should work:

if ($::ec2_instance_id != "") {
...
}

I'll test it before landing.

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 8527382 [details] [diff] [review]
stop_idle_ssh_key-puppet.diff

if ($::ec2_instance_id != "") worked fine

remote:   https://hg.mozilla.org/build/puppet/rev/e79c5d6f88b5
remote:   https://hg.mozilla.org/build/puppet/rev/dc9b0376d8b9

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8527384 [details] [diff] [review]
stop_idle_ssh_key2-puppet.diff

remote:   https://hg.mozilla.org/build/puppet/rev/06ddff0701aa
remote:   https://hg.mozilla.org/build/puppet/rev/326660e0ca37

Comment 8

[Rail Aliiev [:rail]]

Attachment: rm-passwords.json.erb.diff

This template can die now!

I'll delete the corresponding entries from hiera

Comment 9

[Rail Aliiev [:rail]]

Attachment: rm-passwords.json.erb.diff

moar clean up

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8528462 [details] [diff] [review]
rm-passwords.json.erb.diff

*stab* *stab*

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 8528462 [details] [diff] [review]
rm-passwords.json.erb.diff

remote:   https://hg.mozilla.org/build/puppet/rev/71c4dbd600f9
remote:   https://hg.mozilla.org/build/puppet/rev/f3ff098845f8

Comment 12

[Rail Aliiev [:rail]]

Everything is deployed now.