Closed Bug 1103281 Opened 10 years ago Closed 8 years ago

Raspberry-pi build error

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: marcandre.lureau, Assigned: sotaro)

References

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141113113219

Steps to reproduce:

Following build instructions from https://wiki.mozilla.org/Hacking_b2g_on_Raspberry_Pi as of today on both f21 and macosx, and resulted with this early error:

In file included from frameworks/base/include/utils/AssetManager.h:25:0,
                 from frameworks/base/tools/aapt/AaptAssets.h:10,
                 from frameworks/base/tools/aapt/Main.h:14,
                 from frameworks/base/tools/aapt/Main.cpp:6:
frameworks/base/include/utils/KeyedVector.h: In instantiation of ‘const VALUE& android::DefaultKeyedVector<KEY, VALUE>::valueFor(const KEY&) const [with KEY = android::String8; VALUE = android::sp<AaptSymbols>]’:
frameworks/base/tools/aapt/AaptAssets.h:446:59:   required from here
frameworks/base/include/utils/KeyedVector.h:193:31: error: ‘indexOfKey’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
     ssize_t i = indexOfKey(key);
                               ^
frameworks/base/include/utils/KeyedVector.h:193:31: note: declarations in dependent base ‘android::KeyedVector<android::String8, android::sp<AaptSymbols> >’ are not found by unqualified lookup
frameworks/base/include/utils/KeyedVector.h:193:31: note: use ‘this->indexOfKey’ instead

GCC suggestion is indeed enough (I didn't know c++ had this limitation either)

include/utils/KeyedVector.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/utils/KeyedVector.h b/include/utils/KeyedVector.h
index 6bcdea4..5e62755 100644
--- a/include/utils/KeyedVector.h
+++ b/include/utils/KeyedVector.h
@@ -190,7 +190,7 @@ DefaultKeyedVector<KEY,VALUE>::DefaultKeyedVector(const VALUE& defValue)

 template<typename KEY, typename VALUE> inline
 const VALUE& DefaultKeyedVector<KEY,VALUE>::valueFor(const KEY& key) const {
-    ssize_t i = indexOfKey(key);
+    ssize_t i = this->indexOfKey(key);
     return i >= 0 ? KeyedVector<KEY,VALUE>::valueAt(i) : mDefault;
 }
Blocks: fxos-rpi
Second build issue:

... objdir-gecko/gfx/2d/Unified_cpp_gfx_2d1.cpp

In file included from /home/elmarco/src/mozilla/B2G/objdir-gecko/gfx/2d/Unified_cpp_gfx_2d1.cpp:102:
/home/elmarco/src/mozilla/B2G/gecko/gfx/2d/SourceSurfaceSkia.cpp: In member function 'bool mozilla::gfx::Source\
SurfaceSkia::InitFromTexture(mozilla::gfx::DrawTargetSkia*, unsigned int, const mozilla::gfx::IntSize&, mozilla\
::gfx::SurfaceFormat)':
/home/elmarco/src/mozilla/B2G/gecko/gfx/2d/SourceSurfaceSkia.cpp:106: error: 'GfxFormatToGrConfig' was not decl\
ared in this scope
/home/elmarco/src/mozilla/B2G/gecko/gfx/2d/SourceSurfaceSkia.cpp:110: error: 'class mozilla::gfx::DrawTargetSki\
a' has no member named 'mGrContext'


See attached patch
I was this weekend with marc while he was trying to build, and i'm on mac os x 10.10.1 and he's on fedora.

we tried those two os and clearly this patch fix the build issues, it builds correctly now with these patch (and i'm using a casesensitive fs to build all projects).

No we have B2G that segfault, and we are looking around it, when we can.
I can confirm both issues: the second compiler error and the segfault on b2g.
I could compile using the patch from comment #2.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Has this been added to the rpi branch? If not should we update https://wiki.mozilla.org/Hacking_b2g_on_Raspberry_Pi
any news on this?
Flags: needinfo?(mwu)
Depends on: 1214249
Attached file link to pull request
Attachment #8700020 - Flags: review?(mwu)
Flags: needinfo?(mwu)
Attachment #8700020 - Flags: review?(mwu) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee: nobody → sotaro.ikeda.g
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: