Closed
Bug 1103281
Opened 10 years ago
Closed 8 years ago
Raspberry-pi build error
Categories
(Firefox OS Graveyard :: General, defect)
Firefox OS Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: marcandre.lureau, Assigned: sotaro)
References
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0 Build ID: 20141113113219 Steps to reproduce: Following build instructions from https://wiki.mozilla.org/Hacking_b2g_on_Raspberry_Pi as of today on both f21 and macosx, and resulted with this early error: In file included from frameworks/base/include/utils/AssetManager.h:25:0, from frameworks/base/tools/aapt/AaptAssets.h:10, from frameworks/base/tools/aapt/Main.h:14, from frameworks/base/tools/aapt/Main.cpp:6: frameworks/base/include/utils/KeyedVector.h: In instantiation of ‘const VALUE& android::DefaultKeyedVector<KEY, VALUE>::valueFor(const KEY&) const [with KEY = android::String8; VALUE = android::sp<AaptSymbols>]’: frameworks/base/tools/aapt/AaptAssets.h:446:59: required from here frameworks/base/include/utils/KeyedVector.h:193:31: error: ‘indexOfKey’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive] ssize_t i = indexOfKey(key); ^ frameworks/base/include/utils/KeyedVector.h:193:31: note: declarations in dependent base ‘android::KeyedVector<android::String8, android::sp<AaptSymbols> >’ are not found by unqualified lookup frameworks/base/include/utils/KeyedVector.h:193:31: note: use ‘this->indexOfKey’ instead GCC suggestion is indeed enough (I didn't know c++ had this limitation either) include/utils/KeyedVector.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/utils/KeyedVector.h b/include/utils/KeyedVector.h index 6bcdea4..5e62755 100644 --- a/include/utils/KeyedVector.h +++ b/include/utils/KeyedVector.h @@ -190,7 +190,7 @@ DefaultKeyedVector<KEY,VALUE>::DefaultKeyedVector(const VALUE& defValue) template<typename KEY, typename VALUE> inline const VALUE& DefaultKeyedVector<KEY,VALUE>::valueFor(const KEY& key) const { - ssize_t i = indexOfKey(key); + ssize_t i = this->indexOfKey(key); return i >= 0 ? KeyedVector<KEY,VALUE>::valueAt(i) : mDefault; }
Reporter | ||
Comment 1•10 years ago
|
||
Second build issue: ... objdir-gecko/gfx/2d/Unified_cpp_gfx_2d1.cpp In file included from /home/elmarco/src/mozilla/B2G/objdir-gecko/gfx/2d/Unified_cpp_gfx_2d1.cpp:102: /home/elmarco/src/mozilla/B2G/gecko/gfx/2d/SourceSurfaceSkia.cpp: In member function 'bool mozilla::gfx::Source\ SurfaceSkia::InitFromTexture(mozilla::gfx::DrawTargetSkia*, unsigned int, const mozilla::gfx::IntSize&, mozilla\ ::gfx::SurfaceFormat)': /home/elmarco/src/mozilla/B2G/gecko/gfx/2d/SourceSurfaceSkia.cpp:106: error: 'GfxFormatToGrConfig' was not decl\ ared in this scope /home/elmarco/src/mozilla/B2G/gecko/gfx/2d/SourceSurfaceSkia.cpp:110: error: 'class mozilla::gfx::DrawTargetSki\ a' has no member named 'mGrContext' See attached patch
Reporter | ||
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
IIRC, we used to see this error whenever b2g was built on a Mac on a case-insensitive filesystem. https://developer.mozilla.org/en-US/Firefox_OS/Firefox_OS_build_prerequisites#Be_aware_of_Mac_file_system_case_sensitivity
I was this weekend with marc while he was trying to build, and i'm on mac os x 10.10.1 and he's on fedora. we tried those two os and clearly this patch fix the build issues, it builds correctly now with these patch (and i'm using a casesensitive fs to build all projects). No we have B2G that segfault, and we are looking around it, when we can.
Comment 5•9 years ago
|
||
I can confirm both issues: the second compiler error and the segfault on b2g. I could compile using the patch from comment #2.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 6•9 years ago
|
||
We should probably put https://www.codeaurora.org/cgit/quic/la/platform/frameworks/base/commit/?h=b2g_ics_1.2&id=89820fe3eb90807bb1d7f26519b3af04e6f633fe on the rpi branch of frameworks/base.
Comment 7•9 years ago
|
||
Has this been added to the rpi branch? If not should we update https://wiki.mozilla.org/Hacking_b2g_on_Raspberry_Pi
Assignee | ||
Comment 9•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8700020 -
Flags: review?(mwu)
Updated•8 years ago
|
Flags: needinfo?(mwu)
Attachment #8700020 -
Flags: review?(mwu) → review+
Assignee | ||
Comment 10•8 years ago
|
||
https://github.com/mozilla-b2g/platform_frameworks_base/commit/4b5a158eb90ff5ee6d16ba7a90bfa23e88e05eb3
Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sotaro.ikeda.g
You need to log in
before you can comment on or make changes to this bug.
Description
•