Closed Bug 1103411 Opened 7 years ago Closed 7 years ago

EventStateManager may call AddBoolVarCache multiple times and crash

Categories

(Core :: DOM: Events, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file)

With embedlite environment it is possible to create and destroy all gecko dom windows multiple times, and when it happens I see assertion in AddBoolVarCache thrown by AssertNotAlreadyCached.
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #8527232 - Flags: review?(bugs)
Comment on attachment 8527232 [details] [diff] [review]
Don't crash in EventStateManager::Prefs::Init

I would just have a static variable inside EventStateManager::Prefs::Init(), 
but keeping it outside is fine too.
Attachment #8527232 - Flags: review?(bugs) → review+
Re: https://hg.mozilla.org/integration/mozilla-inbound/rev/3690b28c0532

In the future, please write r=smaug rather than r=bugs in the commit message (even though current bugzilla UI shows "bugs: review+").
https://hg.mozilla.org/mozilla-central/rev/3690b28c0532
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.