Closed Bug 1103412 Opened 5 years ago Closed 5 years ago

Gecko does not compile with printing disabled

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(1 file)

No description provided.
I haven't found way to ifdef in ipdl files, so proposal here is to compile printing ipdl and undef only C sources
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #8527233 - Flags: review?(mconley)
Comment on attachment 8527233 [details] [diff] [review]
Fix gecko build with undefined NS_PRINTING

Review of attachment 8527233 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/qt/nsLookAndFeel.cpp
@@ -18,4 @@
>  #include <QFont>
>  #include <QScreen>
>  #include <QPalette>
> -#include <QStyle>

What's going on with these two changes? They look unrelated.
Attachment #8527233 - Flags: review?(mconley)
> > -#include <QStyle>
> 
> What's going on with these two changes? They look unrelated.

I've noticed they are unused and available only in libQtWidgets5 library, which is kinda deprecated. We do enable QtWidgets only when printing enabled, but here it is just unused headers
Comment on attachment 8527233 [details] [diff] [review]
Fix gecko build with undefined NS_PRINTING

Review of attachment 8527233 [details] [diff] [review]:
-----------------------------------------------------------------

This looks sane to me, but as I'm not a DOM or widget peer, I guess I should get one to sign off on this.

smaug - are you OK with the dom/ipc and embedding bits? And jimm, are you OK with the widget bits?

Try build: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5abad9483773
Attachment #8527233 - Flags: review?(jmathies)
Attachment #8527233 - Flags: review?(bugs)
Attachment #8527233 - Flags: feedback+
Attachment #8527233 - Flags: review?(bugs) → review+
Attachment #8527233 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/cadfee0aa2af
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.