1103440 - Not showing pushlog for inbound after bisection complete

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[William Lachance (:wlach)]

It looks like we're not currently showing the pushlog when bisection is complete. When looking into the problem, I found a small family of related problems.

Comment 1

[William Lachance (:wlach)]

Attachment: Fix display of inbound pushlog

This makes sure we print a url like:

 0:25.10 LOG: MainThread Bisector INFO Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c185e41609f85b3ec1cf1f5b5bb110e11ce569b1&tochange=33d0247e5290f0a00bed24cb51ed2d379723f174

... which people can use to post a url to bugzilla.

Comment 2

[Julien Pagès (:parkouss)]

Comment on attachment 8527250 [details] [review]
Fix display of inbound pushlog

Seems good to me - just a little thing that I noted in pull request comment.

While testing this, I found that the way I used to determin the remaining steps is wrong. Good solution is indicated by Mike Hommey in bug Bug 1084950 comment 0.

I will open a bug and fix this today, and thanks him by the way. :)

Comment 3

[Julien Pagès (:parkouss)]

Another little bug found, I made a pull request for that: https://github.com/mozilla/mozregression/pull/135

No bug entry in bugzilla, I don't think it is useful here.

Comment 4

[William Lachance (:wlach)]

Merged PR, made a quick followup fix to address the line comment (sorry, missed that initially)

Comment 5

[Elbart]

Now mozregression is showing the inbound-pushlog even when there are no inbound-builds to test:

15:47.73 LOG: MainThread Bisector INFO Narrowed nightly regression window from [
2013-06-26, 2013-06-28] (2 days) to [2013-06-26, 2013-06-27] (1 days) (~0 steps
left)
15:47.73 LOG: MainThread Bisector INFO Got as far as we can go bisecting nightli
es...
15:47.73 LOG: MainThread Bisector INFO Ensuring we have enough metadata to get a
 pushlog...
15:47.73 LOG: MainThread Bisector INFO Last good revision: cc80aa0c7c13 (2013-06
-26)
15:47.73 LOG: MainThread Bisector INFO First bad revision: 3b955f306226 (2013-06
-27)
15:47.73 LOG: MainThread Bisector INFO Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cc80aa0c7c13&tochan
ge=3b955f306226

15:47.73 LOG: MainThread Bisector INFO ... attempting to bisect inbound builds (
starting from previous week, to make sure no inbound revision is missed)
15:49.04 LOG: MainThread Regression Runner INFO Getting http://ftp.mozilla.org/p
ub/mozilla.org/firefox/nightly/2013/06/2013-06-19-03-10-48-mozilla-central/firef
ox-24.0a1.en-US.win32.txt
15:49.41 LOG: MainThread Bisector INFO Getting inbound builds between d2a7cfa341
54 and 3b955f306226
16:26.62 LOG: MainThread Bisector INFO Oh noes, no (more) inbound revisions :(
16:26.62 LOG: MainThread Bisector INFO Last good revision: d2a7cfa34154
16:26.62 LOG: MainThread Bisector INFO First bad revision: 3b955f306226
16:26.62 LOG: MainThread Bisector INFO Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d2a7cf
a34154&tochange=3b955f306226

do you want to bisect further by fetching the repository and building? (y or n)
n

Should I open a new bug?

Comment 6

[William Lachance (:wlach)]

(In reply to Elbart from comment #5)
> Now mozregression is showing the inbound-pushlog even when there are no
> inbound-builds to test:
> 
> 15:47.73 LOG: MainThread Bisector INFO Narrowed nightly regression window
> from [
> 2013-06-26, 2013-06-28] (2 days) to [2013-06-26, 2013-06-27] (1 days) (~0
> steps
> left)
> 15:47.73 LOG: MainThread Bisector INFO Got as far as we can go bisecting
> nightli
> es...
> 15:47.73 LOG: MainThread Bisector INFO Ensuring we have enough metadata to
> get a
>  pushlog...
> 15:47.73 LOG: MainThread Bisector INFO Last good revision: cc80aa0c7c13
> (2013-06
> -26)
> 15:47.73 LOG: MainThread Bisector INFO First bad revision: 3b955f306226
> (2013-06
> -27)
> 15:47.73 LOG: MainThread Bisector INFO Pushlog:
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=cc80aa0c7c13&tochan
> ge=3b955f306226
> 
> 15:47.73 LOG: MainThread Bisector INFO ... attempting to bisect inbound
> builds (
> starting from previous week, to make sure no inbound revision is missed)
> 15:49.04 LOG: MainThread Regression Runner INFO Getting
> http://ftp.mozilla.org/p
> ub/mozilla.org/firefox/nightly/2013/06/2013-06-19-03-10-48-mozilla-central/
> firef
> ox-24.0a1.en-US.win32.txt
> 15:49.41 LOG: MainThread Bisector INFO Getting inbound builds between
> d2a7cfa341
> 54 and 3b955f306226
> 16:26.62 LOG: MainThread Bisector INFO Oh noes, no (more) inbound revisions
> :(
> 16:26.62 LOG: MainThread Bisector INFO Last good revision: d2a7cfa34154
> 16:26.62 LOG: MainThread Bisector INFO First bad revision: 3b955f306226
> 16:26.62 LOG: MainThread Bisector INFO Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=d2a7cf
> a34154&tochange=3b955f306226
> 
> do you want to bisect further by fetching the repository and building? (y or
> n)
> n
> 
> Should I open a new bug?

Yes, please do. Reproduction steps would be great. :)