110348 - P3P won't compile: string code bitrot

Status: VERIFIED INVALID

(Core :: XPCOM, defect)

Description

[Hixie (not reading bugmail)]

The P3P extensions won't compile right now. One of the reasons (not the only
one, as far as I can tell) is that it is missing a whole slew of newly-required
|.get()|s on string-related stuff.

Comment 1

[Peter Haight]

Attachment: Here's a patch that gets it to compile again.

This patch gets the p3p extension to compile again. The UI has also suffered
from bitrot and I don't have that done yet. I'm sticking this patch in now so
others can build off this.

Comment 2

[Hixie (not reading bugmail)]

should we get that checked in? Do we need r=/sr= for P3P?

Comment 3

[Ben Bucksch (:BenB)]

scc: ping.

Why hasn't P3P been converted with the other mass-changes?

Comment 4

[jag (Peter Annema)]

It hasn't been converted since it's not pulled by default. I'm very willing to
fix all code that's in a normal development tree (which includes the mathml
code, which wasn't built by default at that time), but code like this is on its own.

I don't know what the checkin rules are for this P3P code, but since I suspect
people will want it to become part of the base build, it'll probably need r= and
sr=.

You have my blanket rs= (rubberstamp) for all simple changes needed to convert
to the new string APIs (adding .get(), changing from XXXWithConversion to XXX
with some converter, and adding unicharutil to makefiles + including
nsUnicharUtils.h). Get an r= on these changes and check them in.

For the other changes in the above patch you should bug someone to do a proper
super review (could be me, but not right now).

Comment 5

[Ben Bucksch (:BenB)]

> It hasn't been converted since it's not pulled by default.

It seems liek it is pulled by deafult now. I did an ordinary make -f client.mk
checkout and I have it in extensions/p3p/.

> I'm very willing to
> fix all code that's in a normal development tree (which includes the mathml
> code, which wasn't built by default at that time)

ah, good.

Comment 6

[jag (Peter Annema)]

Ah, for the .get() case it was a matter of |build; while (bustage) {fix bustage;
build;}|, in which case I only end up fixing what's built on the tinderboxen.
I'm sorry that P3P missed out on me making these string API changes, but right
now I have better things to work on. I'm sure someone who's been working on the
P3P code can go in and fix things, I'll be around if any questions arise.

Comment 7

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Old P3P code has been removed, INVALID.

Comment 8

[John Unruh]

Verified.