1103573 - browser_scratchpad_contexts.js leaks on osx 10.8 while run as a standalone directory

Status: RESOLVED WORKSFORME

(DevTools Graveyard :: Scratchpad, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

this happens about 50-70% of the time, we have been switching our method of test running from "run a big pile of tests" to "run all the tests in a given directory, then close the browser".  This method works great, but it causes a few tests to have problems, specifically browser_scratchpad_contexts.js.

Oddly enough this only happens on osx 10.8, and not on any other platform.  This is in the debug tests on dt2.  Here is a try push exhibiting the error:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c91512a202f6

and a try push with this single test commented out:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=03f9f8648d67

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

there is a person named [e-mail] who checked in code last, but they don't resolve in bugzilla.

Brandon, can you take a look at this or find the right person to look into it?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

On try server I narrowed down the specific test case which is causing problems:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c06583104315

This is the specific test which causes problems:
http://dxr.mozilla.org/mozilla-central/source/browser/devtools/scratchpad/test/browser_scratchpad_contexts.js#90

and it was modified in this bug recently:
https://bugzilla.mozilla.org/show_bug.cgi?id=912260

I found Anton's bugzilla account, Anton, can you look into this and help figure out why this is causing a leak when run as a standalone directory (./mach mochitest-devtools browser/devtools/scratchpad/test) ?

Comment 3

[Anton Kovalyov (:anton)]

Sorry, I have neither time nor resources to look into this these days.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

:anton, Is there someone else that could handle this?  I have narrowed this down pretty far, but my expertise isn't in this area.  I would rather fix this than temporarily disable it.

Comment 5

[Anton Kovalyov (:anton)]

Someone who's still on the Developer Tools team? Nick Fitzgerald maybe?

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Hi Nick, can you help out here?

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I don't have the cycles right now, sorry. If I were to guess, I'd think something is either not destroying the editor, or keeping a reference accidentally.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

ok, this doesn't reproduce anymore, sorry for randomizing you guys.