1103574 - Use Web Audio API to play keyboard clicker sounds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Currently we play these sounds with <audio> tags and some platforms does not handle multiple tags quite well (*cough* iOS *cough*). By switching to Web Audio API it would help us remove some issues.

I have a patch ready.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

However, my patch does release audioContext when the keyboard is hidden since FeedbackPlayer and it's children does not get any events when the keyboard is hidden (except the global visibilitychange).

I am not sure if this a strong requirement or not -- yet.

Comment 2

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#26397

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8527496 [details] [review]
mozilla-b2g:master PR#26397

The tests takes more time to set up than the code because the code kinds of talk to two APIs at once, but I think this is good enough for review.

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8527496 [details] [review]
mozilla-b2g:master PR#26397

Good job on creating those mocks and interfacing them with the tests (Y)

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=0144634afcc8

master: https://github.com/mozilla-b2g/gaia/commit/1917c4dfb81953a1f9c688780ba702fea4229d1b