1103589 - Link opened from Private Browsing window opens in regular browser window

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[mac]

User Agent: Mozilla/5.0 (Tablet; rv:36.0) Gecko/36.0 Firefox/36.0
Build ID: 20141122020839

Steps to reproduce:

1. Open the Browser in Private Browsing mode
2. Open web page in the Browser window from previous point where are links that opens in new windows
3. Tap on link from previous point that opens in a new browser window


Actual results:

Link opens in regular browser window with all of it consequences - history, cookies and etc


Expected results:

Such link must be opened in new browser window but also in Private Browsing mode.

Found on:
Foxconn InFcocus F1 tablet (TCP)
B2G version: 2.2.0.0-prerelease master
Platform version: 36.0a1
Build Identifier: 20141122015935
Git commit info: 2014-11-21 16:13:14 6ed3c563

Alcatel One Touch Fire production (got from T-mobile Poland)
B2G version: 2.2.0.0-prerelease master
Platform version: 36.0a1
Build Identifier: 20141122180308
Git commit info: 2014-11-22 08:56:01 d1a128fa

Comment 1

[Kevin Grandon :kgrandon]

Thanks for filing. Seems like this should open in a new private browsing window indeed.

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1103589_private_browser_new_window to mozilla-b2g:master

Comment 3

[Kevin Grandon :kgrandon]

Here's a WIP pull request which fixes the issue. I just need to write a quick marionette test for it.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8527938 [details] [review]
[PullReq] KevinGrandon:bug_1103589_private_browser_new_window to mozilla-b2g:master

I've added a simple test to this now. George - could you help me review this patch?

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8527938 [details] [review]
[PullReq] KevinGrandon:bug_1103589_private_browser_new_window to mozilla-b2g:master

LGTM, r=gduan.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8527938 [details] [review]
[PullReq] KevinGrandon:bug_1103589_private_browser_new_window to mozilla-b2g:master

Add my R for autolander.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/acde76b558f72224040460375ca9d5c5f2f01c00