Closed
Bug 110360
Opened 23 years ago
Closed 23 years ago
list numbers not using font-size from CSS
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: rodd, Assigned: dbaron)
References
()
Details
(Keywords: regression, testcase)
Attachments
(3 files, 1 obsolete file)
634 bytes,
text/html
|
Details | |
773 bytes,
text/html
|
Details | |
3.88 KB,
patch
|
karnaze
:
review+
attinasi
:
superreview+
|
Details | Diff | Splinter Review |
<ol> tag not using font-family in CSS. This may also affect <ul> but I wouldn't know how to tell. Also, the font-size element might also be ignored. Sample html: <ol class="helpOn"> <li class="helpOn">a list item</li> <li class="helpOn">another item in list</li> </ol> Sample CSS: .helpOn:hover { font-family: Arial, Helvetica, Lucida, sans-serif; color: #000000; font-size: 13px; font-weight: normal; text-decoration: none; } I would expect the ordered numbers to have the same font and size as the text as the text in the list items. They don't.
its font-size not font-family
OS: Linux → All
Summary: <ol> tag not using font-family in CSS → <ol> tag not using font-size in CSS
reporter was using 2001111109 Linux trunk I'm using 2001111203 Win32 trunk and kmeleon5 sodabot from #mozillazine 2001111303 Win32 trunk
OS: Linux → All
the testcase mentioned by the reporter is besides the point. I'll attach a testcase
the attached testcase show that mozilla does not use the "font-size" property in the list numbers
Reporter | ||
Comment 8•23 years ago
|
||
Ooops. I posted up the the wrong line out of my css file when posting the original example, and it might have confused a few people into thinking this had something to do with the :hover part. The CSS should have been: .helpOn { font-family: Arial, Helvetica, Lucida, sans-serif; color: #000000; font-size: 13px; font-weight: normal; text-decoration: none; } Basic's example above is a good example of what is going wrong.
Assignee | ||
Updated•23 years ago
|
Summary: <ol> tag not using font-size in CSS → list numbers not using font-size from CSS
Comment 10•23 years ago
|
||
maybe this blocks bug 91672 ? rule tree stuff?
Comment 11•23 years ago
|
||
Pierre: could you check if this is another one of the rule tree landing regressions (aka bug 91672)?
Comment 12•23 years ago
|
||
It is a regression that happened sometime between 08/30 and 09/24: nothing to do with the rule tree. It is probably related to bug 96031 / bug 22899.
Comment 13•23 years ago
|
||
*** Bug 112878 has been marked as a duplicate of this bug. ***
Keywords: mozilla0.9.7
Comment 14•23 years ago
|
||
*** Bug 113598 has been marked as a duplicate of this bug. ***
Comment 15•23 years ago
|
||
Confirm under Mac -> Platform All
Keywords: mozilla0.9.9
Comment 16•23 years ago
|
||
This is a pretty serious regression. you can't control the size of the numbers in an ordered list. see test case: http://www.cherny.com/mozilla/lists/liststest.html I think this is pretty bad. i'd like to think this could get fixed ASAP. These regressions are bad news. This worked fine in earlier mozillas and went bad somewhere around the milestones used for NS 6.2 ... works fine in NS6.0, 6.1 ... :rob
Assignee | ||
Comment 17•23 years ago
|
||
It turns out this was done intentionally, to "fix" bug 97351. To really fix that bug requires parenting the list bullet's style context to the parent of the block it's related to rather than to the block itself.
Comment 18•23 years ago
|
||
Yes, this was done to fix another bug (IE compat). However, I thought I tested the OL case - apparently I did not do it right. Having style context parentage differ from frame parentage is freightening to me. I think there are assumptions that the trees match, and only tables break that AFAIK. I can think of two other approaches: 1) change the selector to ul > li:-moz-list-bullet { font-size: -moz-initial; } 2) change the pseudo used for numerals to -moz-list-numeral so we can differentiate between the two cases. In an email I received from Luke Stone, he suggested we hack the bullet sizing code to implement the quirk. Something like checking for quirks mode and then using the default font size for the bullets rather than the size in the style struct. I personally prefer the child-selector approach, but only because it is easier and it will allow me to go back to fixing the crashers I have on my plate.
Assignee | ||
Comment 19•23 years ago
|
||
But is bug 97351 even fixed for the case where the UL has a non-default font size?
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
Assignee | ||
Comment 20•23 years ago
|
||
This is a possible fix. I haven't yet tested it, or even compiled it. I also haven't yet had a chance to test the IE behavior that we're trying to imitate.
Assignee | ||
Comment 21•23 years ago
|
||
To get it to compile, I have to move these 2 lines up: const nsStyleList* styleList; GetStyleData(eStyleStruct_List, (const nsStyleStruct*&) styleList);
Assignee | ||
Comment 22•23 years ago
|
||
Assignee | ||
Comment 23•23 years ago
|
||
Comment on attachment 70092 [details]
testcase showing possibilities
Oops. Some of the OL testcases say UL.
Attachment #70092 -
Attachment is patch: false
Attachment #70092 -
Attachment mime type: text/plain → text/html
Assignee | ||
Comment 24•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Attachment #70074 -
Attachment is obsolete: true
Assignee | ||
Comment 25•23 years ago
|
||
Comment on attachment 70092 [details]
testcase showing possibilities
WinIE 5.5 displays this testcase with all bullets the same size but the number
always the same size as the LI text. That's what my patch makes Mozilla do.
Comment 26•23 years ago
|
||
Comment on attachment 70093 [details] [diff] [review] working patch sr=attinasi - exactly what I was thinking...
Attachment #70093 -
Flags: superreview+
Updated•23 years ago
|
Attachment #70093 -
Flags: review+
Comment 27•23 years ago
|
||
Comment on attachment 70093 [details] [diff] [review] working patch r=karnaze, I guess styleList can never be null.
a=roc+moz for 0.9.9
Assignee | ||
Comment 29•23 years ago
|
||
Fix checked in 2002-02-20 17:36 PST.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•23 years ago
|
Keywords: mozilla0.9.9 → mozilla0.9.9+
Comment 30•23 years ago
|
||
*** Bug 127849 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•