Closed Bug 1103613 Opened 9 years ago Closed 9 years ago

Use better inline-size for orthogonal flows

Categories

(Core :: Layout: Block and Inline, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(3 files)

See testcase. The inner test <div> is contained by a block with specified dimensions, which we should respect when setting the inline-size on the inner element regardless of whether it has the same or orthogonal orientation.

(Compare webkit's behavior with the same testcase.)
Does this seem reasonable? My initial testing indicates that it produces a much better result.
Attachment #8527324 - Flags: review?(smontagu)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
(In reply to Jonathan Kew (:jfkthame) from comment #0)
> See testcase. 

Which testcase? I think the patch makes sense, but I'd like to see the testcase.
Attached file testcase
Oops, sorry! Here it is.
Comment on attachment 8527324 [details] [diff] [review]
Use better inline-size for an orthogonal flow within a block of specified dimensions.

Review of attachment 8527324 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, that seems reasonable
Attachment #8527324 - Flags: review?(smontagu) → review+
And here's a reftest based on the example.
Attachment #8527728 - Flags: review?(smontagu)
Comment on attachment 8527728 [details] [diff] [review]
Reftest for inline-size of an orthogonal block.

Review of attachment 8527728 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/writing-mode/1103613-1.html
@@ +4,5 @@
> +<meta charset="utf-8">
> +<style>
> +#outer {
> +  height: 200px;
> +  width: 200px;

I think as a general principle it's a good idea to make height and width different in these tests.
Attachment #8527728 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/656caf712135
https://hg.mozilla.org/integration/mozilla-inbound/rev/c81c01e10565

(In reply to Simon Montagu :smontagu from comment #6)

> I think as a general principle it's a good idea to make height and width
> different in these tests.

Oops, I forgot to adjust this before pushing the test; I'll do it in a followup.
Target Milestone: --- → mozilla36
Followup to use different height and width in the test, as per comment 6:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01c8dc6a07c3
Depends on: 1243125
You need to log in before you can comment on or make changes to this bug.