Closed Bug 1103622 Opened 9 years ago Closed 9 years ago

PlacesTransactions.Annotate for multiple items

Categories

(Toolkit :: Places, defect)

defect
Not set
normal
Points:
3

Tracking

()

RESOLVED FIXED
mozilla36
Iteration:
37.1

People

(Reporter: asaf, Assigned: asaf)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
      No description provided.
Attachment #8527331 - Flags: review?(mak77)
Note: I'm abusing this bug for yield-rootGuid removal in the test.
Flags: qe-verify-
Comment on attachment 8527331 [details] [diff] [review]
patch

Review of attachment 8527331 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/PlacesTransactions.jsm
@@ +67,5 @@
>   *            a live bookmark is associated.
>   *  - tag - a string.
>   *  - tags: an array of strings.
>   *  - guid, parentGuid, newParentGuid: a valid places GUID string.
> + *  - guids: an array of valid places GUID strings.

really-nit: ucfirst Places

::: toolkit/components/places/tests/unit/test_async_transactions.js
@@ +251,1 @@
>  }

nit: fwiw, now this is not very useful and could be hardcoded...

@@ +1010,5 @@
>  });
>  
>  add_task(function* test_edit_keyword() {
> +  let bm_info = { parentGuid: rootGuid
> +                , url: NetUtil.newURI("http://test.edit.keyword") };

don't we also accept URL or href now?

@@ +1541,5 @@
> +add_task(function* test_annotate_multiple_items() {
> +  let parentGuid = rootGuid;
> +  let guids = [
> +    yield PT.NewBookmark({ url: "about:blank", parentGuid }).transact(),
> +    yield PT.NewFolder({ title: "Test Folder", parentGuid }).transact()];

nit: "];" on new line please
Attachment #8527331 - Flags: review?(mak77) → review+
Marco, please add this bug to the current (last) iteration.
Flags: firefox-backlog+
Iteration: 36.3 → 37.1
https://hg.mozilla.org/mozilla-central/rev/1ad2becc23b3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.