Closed
Bug 1103622
Opened 9 years ago
Closed 9 years ago
PlacesTransactions.Annotate for multiple items
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
People
(Reporter: asaf, Assigned: asaf)
References
Details
Attachments
(1 file)
27.57 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8527331 -
Flags: review?(mak77)
Assignee | ||
Comment 1•9 years ago
|
||
Note: I'm abusing this bug for yield-rootGuid removal in the test.
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify-
Comment 2•9 years ago
|
||
Comment on attachment 8527331 [details] [diff] [review] patch Review of attachment 8527331 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/places/PlacesTransactions.jsm @@ +67,5 @@ > * a live bookmark is associated. > * - tag - a string. > * - tags: an array of strings. > * - guid, parentGuid, newParentGuid: a valid places GUID string. > + * - guids: an array of valid places GUID strings. really-nit: ucfirst Places ::: toolkit/components/places/tests/unit/test_async_transactions.js @@ +251,1 @@ > } nit: fwiw, now this is not very useful and could be hardcoded... @@ +1010,5 @@ > }); > > add_task(function* test_edit_keyword() { > + let bm_info = { parentGuid: rootGuid > + , url: NetUtil.newURI("http://test.edit.keyword") }; don't we also accept URL or href now? @@ +1541,5 @@ > +add_task(function* test_annotate_multiple_items() { > + let parentGuid = rootGuid; > + let guids = [ > + yield PT.NewBookmark({ url: "about:blank", parentGuid }).transact(), > + yield PT.NewFolder({ title: "Test Folder", parentGuid }).transact()]; nit: "];" on new line please
Attachment #8527331 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1ad2becc23b3
Assignee | ||
Comment 4•9 years ago
|
||
Marco, please add this bug to the current (last) iteration.
Updated•9 years ago
|
Flags: firefox-backlog+
Updated•9 years ago
|
Iteration: 36.3 → 37.1
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1ad2becc23b3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•