Closed Bug 1103623 Opened 9 years ago Closed 9 years ago

Port most remaining gfxContext::Fill() calls to Moz2D

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

      No description provided.
Attached patch patchSplinter Review
Attachment #8527333 - Flags: review?(matt.woodrow)
Comment on attachment 8527333 [details] [diff] [review]
patch

Review of attachment 8527333 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/DisplayItemClip.cpp
@@ +129,5 @@
>    DrawTarget& aDrawTarget = *aContext->GetDrawTarget();
>  
>    aEnd = std::min<uint32_t>(aEnd, mRoundedClipRects.Length());
>  
> +  if (aEnd - aBegin <= 0) {

This seems misleading to me; because these are both u32, it can't be < 0.
Blocks: 1087960
Comment on attachment 8527333 [details] [diff] [review]
patch

Review of attachment 8527333 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/DisplayItemClip.cpp
@@ +129,5 @@
>    DrawTarget& aDrawTarget = *aContext->GetDrawTarget();
>  
>    aEnd = std::min<uint32_t>(aEnd, mRoundedClipRects.Length());
>  
> +  if (aEnd - aBegin <= 0) {

if (aBegin >= aEnd) ?
Attachment #8527333 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8527333 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/e497957b79b2

(In reply to Matt Woodrow (:mattwoodrow) from comment #3)
> if (aBegin >= aEnd) ?

Heh. Yeah, changed.
Attachment #8527333 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/e497957b79b2
https://hg.mozilla.org/mozilla-central/rev/4a7e6c993f1c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Depends on: 1148418
You need to log in before you can comment on or make changes to this bug.