1103627 - [System] Use a marionette client loader to include the system app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1103627_marionette_client_loader_system to mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8527339 [details] [review]
[PullReq] KevinGrandon:bug_1103627_marionette_client_loader_system to mozilla-b2g:master

Hello guys, I would like to start creating some simple loaders for app/region logic in a shared way and begin porting test classes over to this format. This would make test maintenance and cross-app understanding of tests easier. I think you guys might make good reviewers for this initial change. Once this is done I will follow it up with a few app file ports, see Bug 1103629 / Bug 1103628.

The main part of this is the simple plugin for loading of files here:  https://github.com/mozilla-b2g/gaia/pull/26383/files#diff-6afea9a84379ea99eb238fec6929ef08R7

I'd like to keep the loader internal to gaia for now as I imagine I'll be iterating quite a bit over it, and the package publishing dance is a bit of a pain. We can always move it out of gaia in the future. Let me know what you think!

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8527339 [details] [review]
[PullReq] KevinGrandon:bug_1103627_marionette_client_loader_system to mozilla-b2g:master

The proof is in the green pudding :)

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8527339 [details] [review]
[PullReq] KevinGrandon:bug_1103627_marionette_client_loader_system to mozilla-b2g:master

Thanks guys. I've also gotten what I think is a verbal R+ from James over IRC so I feel good about this. Going to land and start working on porting other scripts as well.

Comment 5

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/058396f87be087abce7288ddcc5894fdb0feb508

Let the refactoring begin!