Closed Bug 1103629 Opened 10 years ago Closed 10 years ago

[HomeScreen] Use a marionette client loader to include the home screen app

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[PullReq] KevinGrandon:bug_1103629_marionette_client_loader_verticalhome to mozilla-b2g:master
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
+++ This bug was initially created as a clone of Bug #1103627 +++
Comment on attachment 8527340 [details] [review]
[PullReq] KevinGrandon:bug_1103629_marionette_client_loader_verticalhome to mozilla-b2g:master

Chris - I'm trying to clean up our require() mess a bit here. Could you help me review this? Thanks!
Attachment #8527340 - Flags: review?(chrislord.net)
Comment on attachment 8527340 [details] [review]
[PullReq] KevinGrandon:bug_1103629_marionette_client_loader_verticalhome to mozilla-b2g:master

Nice bit of clean up - given that, I don't think it's appropriate for me to r+ until the tests pass, but consider this a spiritual r+ :)
Attachment #8527340 - Flags: review?(chrislord.net)
Comment on attachment 8527340 [details] [review]
[PullReq] KevinGrandon:bug_1103629_marionette_client_loader_verticalhome to mozilla-b2g:master

Tests are green now with a minor change, so I'm going to take your spiritual review, as well as r=me as this is only a simple test change (just a lot of files). Thanks for looking!
Attachment #8527340 - Flags: review+
Keywords: checkin-needed
Whiteboard: [systemsfe]
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: