Closed Bug 1103636 Opened 9 years ago Closed 9 years ago

PlacesTransactions.Remove(guids), PlacesTransactions.RemoveBookmarksForUrls

Categories

(Toolkit :: Places, defect)

defect
Not set
normal
Points:
3

Tracking

()

RESOLVED FIXED
mozilla36
Iteration:
37.1

People

(Reporter: asaf, Assigned: asaf)

References

Details

Attachments

(1 file)

Attached patch patch.diffSplinter Review
      No description provided.
Attachment #8527349 - Flags: review?(mak77)
Assignee: nobody → mano
OS: Mac OS X → All
Hardware: x86 → All
Flags: qe-verify-
Comment on attachment 8527349 [details] [diff] [review]
patch.diff

Review of attachment 8527349 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/unit/test_async_transactions.js
@@ +1621,5 @@
> +  yield PT.redo();
> +  yield ensureNonExistent(...guids);
> +
> +  // Cleanup
> +  PT.clearTransactionsHistory();

shouldn't you yield on this?

@@ +1652,5 @@
> +
> +  // Cleanup.
> +  yield PT.redo();
> +  yield ensureNonExistent(...guids);
> +  PT.clearTransactionsHistory();

ditto
Attachment #8527349 - Flags: review?(mak77) → review+
Marco, please add this bug to the current (36.3) iteration.
Status: NEW → ASSIGNED
Flags: firefox-backlog+
Iteration: 36.3 → 37.1
https://hg.mozilla.org/mozilla-central/rev/03d7928d03df
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.