Closed
Bug 1103636
Opened 9 years ago
Closed 9 years ago
PlacesTransactions.Remove(guids), PlacesTransactions.RemoveBookmarksForUrls
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
People
(Reporter: asaf, Assigned: asaf)
References
Details
Attachments
(1 file)
6.77 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8527349 -
Flags: review?(mak77)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mano
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify-
Comment 1•9 years ago
|
||
Comment on attachment 8527349 [details] [diff] [review] patch.diff Review of attachment 8527349 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/places/tests/unit/test_async_transactions.js @@ +1621,5 @@ > + yield PT.redo(); > + yield ensureNonExistent(...guids); > + > + // Cleanup > + PT.clearTransactionsHistory(); shouldn't you yield on this? @@ +1652,5 @@ > + > + // Cleanup. > + yield PT.redo(); > + yield ensureNonExistent(...guids); > + PT.clearTransactionsHistory(); ditto
Attachment #8527349 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/03d7928d03df
Assignee | ||
Comment 3•9 years ago
|
||
Marco, please add this bug to the current (36.3) iteration.
Updated•9 years ago
|
Status: NEW → ASSIGNED
Flags: firefox-backlog+
Updated•9 years ago
|
Iteration: 36.3 → 37.1
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/03d7928d03df
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•