Closed
Bug 1103640
Opened 9 years ago
Closed 9 years ago
DeviceActor fails when no browser window
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(1 file)
2.64 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
The DeviceActor has code: let win = Services.wm.getMostRecentWindow(DebuggerServer.chromeWindowType); that fails to work correctly when |win| is null - as it will be for xpcshell tests. The following attachment makes it skip those attributes which are derived from such a window. With this patch, WebIDE connects to the xpcshell tests.
Attachment #8527356 -
Flags: feedback?(past)
Comment on attachment 8527356 [details] [diff] [review] 0002-Bug-XXXXXXX-Allow-DeviceActor-to-work-when-no-browse.patch Stealing review, seems fine to me.
Attachment #8527356 -
Flags: feedback?(past) → review+
Component: Developer Tools → Developer Tools: WebIDE
Assignee | ||
Comment 2•9 years ago
|
||
Thanks! https://hg.mozilla.org/integration/fx-team/rev/2faabeaf92c8
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2faabeaf92c8 https://hg.mozilla.org/mozilla-central/rev/4991397b35e9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•