Closed Bug 1103651 Opened 5 years ago Closed 5 years ago

Move content/test/ into dom/

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: heycam, Assigned: poiru)

References

Details

Attachments

(2 files, 3 obsolete files)

Not sure why content/test/reftest/ got missed from bug 946065 work.  Let's move all these tests under layout/reftests/.
Moving all the bug*.html tests to layout/reftests/bugs/, dropping the "bug" prefix, and the odd-one-out optiontext.html to layout/reftests/html/select/.
Attachment #8527366 - Flags: review?(dbaron)
Attachment #8527366 - Attachment is patch: true
Attachment #8527366 - Attachment is obsolete: true
Attachment #8527366 - Flags: review?(dbaron)
Attachment #8527415 - Flags: review?(dbaron)
Why layout/? Those are DOM tests.
There's a bunch of tests under layout/reftests/ that aren't testing specific CSS features, but are testing the rendering of some other features (like DOM stuff).  I think unless we decide that reftests should be scattered about the tree like mochitests/xpcshell/etc. tests are, they should go under layout/reftests/.
I think I tend to lean on the side of having them be in dom/ rather than layout/ as well, although I could probably be convinced.
... but we should probably ask some DOM peers.
Flags: needinfo?(peterv)
Flags: needinfo?(bugs)
I don't have strong feeling about this, but in general I prefer keeping the tests close to the code they are testing. So maybe moving from content/ to dom/ would be better.
Flags: needinfo?(bugs)
Comment on attachment 8527365 [details] [diff] [review]
Part 1: Move content/tests/reftest/xml-stylesheet to layout/reftests/

ok, let's put these in dom instead (unless peterv says otherwise)
Flags: needinfo?(peterv)
Attachment #8527365 - Flags: review?(dbaron) → review-
Attachment #8527415 - Flags: review?(dbaron) → review-
Stealing this.
Assignee: cam → birunthan
Attachment #8527365 - Attachment is obsolete: true
Attachment #8527415 - Attachment is obsolete: true
Attachment #8622771 - Flags: review?(mrbkap)
Summary: move content/test/reftest/ into layout/reftests/ → Move content/test/ into dom/
dom/base/test/ already contains a few DOMParser tests so moving these there.
Attachment #8622772 - Flags: review?(mrbkap)
Attachment #8622771 - Flags: review?(mrbkap) → review+
Attachment #8622772 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/cd97bdca4213
https://hg.mozilla.org/mozilla-central/rev/5089bfbf5787
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.