Closed
Bug 1103652
Opened 10 years ago
Closed 10 years ago
test_animSVGImage*.html should listen for FRAME_UPDATE and not FRAME_COMPLETE
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: seth, Assigned: seth)
References
Details
Attachments
(1 file, 1 obsolete file)
7.17 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
FRAME_COMPLETE is only delivered when the first frame on an image is finished decoding - that is, it's only delivered once, and ProgressTracker enforces that. test_animSVGImage2.html assumes that it's delivered for every frame, which seems to have led to the intermittent orange in bug 1084308. While I'm at it, I'll also fix bug 1058087, as the fix is trivial.
Assignee | ||
Updated•10 years ago
|
Component: SVG → ImageLib
Assignee | ||
Comment 1•10 years ago
|
||
(Whoops! Actually bug 1058087 is fixed already, it seems. I had noticed it pop up in the possibly-duplicate bugs list and thought it was still open.)
No longer blocks: 1058087
Assignee | ||
Comment 2•10 years ago
|
||
Changing the title as test_animSVGImage.html has the same bug.
Summary: test_animSVGImage2.html should listen for FRAME_UPDATE and not FRAME_COMPLETE → test_animSVGImage*.html should listen for FRAME_UPDATE and not FRAME_COMPLETE
Assignee | ||
Comment 3•10 years ago
|
||
Actually, I take that back! test_animSVGImage.html does not listen for either FRAME_UPDATE or FRAME_COMPLETE, it just polls using setTimeout(1). Its author called the timeout function "myOnStopFrame", which is misleading. That should still be changed.
Assignee | ||
Comment 4•10 years ago
|
||
Here's the fix. test_animSVGImage2.html should no longer give intermittent oranges, and it should be a little more clear what's happening in test_animSVGImage.html.
Attachment #8527498 -
Flags: review?(tnikkel)
Assignee | ||
Comment 5•10 years ago
|
||
After looking it over a little more, I realized that test_animSVGImage2.html needed a couple more tweaks. - The gTimer stuff is totally unnecessary. I removed it. - I added more robust guards against logging results after SimpleTest.finish() is called.
Attachment #8527510 -
Flags: review?(tnikkel)
Assignee | ||
Updated•10 years ago
|
Attachment #8527498 -
Attachment is obsolete: true
Attachment #8527498 -
Flags: review?(tnikkel)
Updated•10 years ago
|
Attachment #8527510 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Thanks for the review! Pushed: remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/bb51e79ff4fa
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bb51e79ff4fa
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•