1103676 - Use INSTALL_TARGETS and misc tier in build/Makefile.in

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

build/Makefile.in has a lot of INSTALL_TARGETS in libs and some manual install rules. Let's get everything on INSTALL_TARGETS in the misc tier.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1103676/gps

Comment 2

[Gregory Szorc [:gps]]

/r/925 - Bug 1103676 - Use INSTALL_TARGETS and misc tier in build/Makefile.in

Pull down this commit:

hg pull review -r 40aafe95b5792df1ac775dc69879f43faecd1077

Comment 3

[Gregory Szorc [:gps]]

/r/925 - Bug 1103676 - Use INSTALL_TARGETS and misc tier in build/Makefile.in
/r/927 - Bug 1103676 - Use INSTALL_TARGETS and misc tier in build/unix/Makefile.in

Pull down these commits:

hg pull review -r 091193745c4fd8b2ebdc7715c510e15f680e3ded

Comment 4

[Gregory Szorc [:gps]]

https://tbpl.mozilla.org/?tree=Try&rev=091193745c4f

Comment 5

[Gregory Szorc [:gps]]

/r/925 - Bug 1103676 - Use INSTALL_TARGETS and misc tier in build/Makefile.in
/r/927 - Bug 1103676 - Use INSTALL_TARGETS and misc tier in build/unix/Makefile.in

Pull down these commits:

hg pull review -r e71acc51b9ff0c4b50227c0321da60f0b1e3a418

Comment 6

[Michael Shal [:mshal]]

Does the latest (#c5) have a green try push?

Comment 7

[Gregory Szorc [:gps]]

Yes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=74025ae74d6d

Comment 8

[Michael Shal [:mshal]]

Hmm, although the patch looks fine as far as I can tell, something seems wrong at least with fix_linux_stack.py and fix_stack_using_bpsyms.py:

20:53:42     INFO -  tar: fix_stack_using_bpsyms.py: Cannot stat: No such file or directory
20:53:42     INFO -  tar: fix_linux_stack.py: Cannot stat: No such file or directory

When I tried it out locally, I don't get these files in obj/dist/bin either. Am I missing something?

Comment 9

[Michael Shal [:mshal]]

(Those errors are from your try push, not my local build btw: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-74025ae74d6d/try-linux/try-linux-bm75-try1-build4489.txt.gz )

Comment 11

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1103676 - Use INSTALL_TARGETS and misc tier in build/Makefile.in

Comment 12

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1103676 - Use INSTALL_TARGETS and misc tier in build/unix/Makefile.in

Comment 13

[Nathan Froyd [:froydnj]]

build/{,unix/}Makefile.in have gone away since this bug was opened.