Closed Bug 1103692 Opened 10 years ago Closed 9 years ago

ReferenceError: bundle is not defined in webrtcUI.jsm

Categories

(Firefox :: Site Permissions, defect)

Product:
Firefox
Component:
Site Permissions
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 38
Iteration:
38.1 - 26 Jan
Tracking Flags:
Tracking Status
firefox34 --- unaffected
firefox35 --- unaffected
firefox36 + verified
firefox37 + verified
firefox38 --- verified

People

(Reporter: marco, Assigned: florian)

References

Details

(Keywords: regression)

Attachments

(1 file)

Fix
1.23 KB, patch
Felipe
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
Blocks: 1095733
status-firefox34: --- → unaffected
status-firefox35: --- → unaffected
status-firefox36: --- → affected
Component: Untriaged → General
Keywords: regression
OS: Linux → All
Hardware: x86_64 → All
Component: General → Device Permissions
Blocks: 1120546
[Tracking Requested - why for this release]:
This is beta now and very much not shippable.
tracking-firefox36: --- → ?
Attached patch Fix — — Splinter Review 
I would have usually marked this a mentored, but given that this makes my new tests from bug 1120546 fail, I need this fixed soon.
Assignee: nobody → florian
Attachment #8547703 - Flags: review?(felipc)
Points: --- → 1
status-firefox37: --- → affected
tracking-firefox36: ? → +
tracking-firefox37: --- → +
Flags: qe-verify+
Flags: firefox-backlog+
Steps to reproduce for QA:
- Load: data:text/html,<iframe src="http://queze.net/goinfre/ff_gum_test.html"></iframe>
- Share "Video", and accept sharing in the prompt.
- Open the sharing menu. On Mac it's in "Window" -> "Tabs sharing devices".

Expected result:
This menu should contain an item saying "Unknown origin (camera)".

Actual result:
ReferenceError: bundle is not defined in webrtcUI.jsm in the browser console.
Status: NEW → ASSIGNED
Iteration: --- → 37.3 - 12 Jan
Iteration: 37.3 - 12 Jan → 38.1 - 26 Jan
Attachment #8547703 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/0b8ec9a2c5e3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Florian, could you fill the uplift requests to aurora & beta? Merci!
Flags: needinfo?(florian)
Comment on attachment 8547703 [details] [diff] [review]
Fix

Approval Request Comment
[Feature/regressing bug #]: regression from bug 1095733
[User impact if declined]: broken device sharing UI in the edge case mentioned in comment 3.
[Describe test coverage new/current, TreeHerder]: automated tests added in bug 1120546 for 38. QA will verify on other branches.
[Risks and why]: very low, trivial fix in a code path only used for this edge case.
[String/UUID change made/needed]: none.
Flags: needinfo?(florian)
Attachment #8547703 - Flags: approval-mozilla-beta?
Attachment #8547703 - Flags: approval-mozilla-aurora?
Attachment #8547703 - Flags: approval-mozilla-beta?
Attachment #8547703 - Flags: approval-mozilla-beta+
Attachment #8547703 - Flags: approval-mozilla-aurora?
Attachment #8547703 - Flags: approval-mozilla-aurora+
Reproduced the initial issue using an old Nightly, verified as fixed using latest Nightly on Windows 8 32-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5. Will verify across platforms using Aurora and Beta as well when the patch lands there. 
Will mark this bug as Verified though since it reached the target milestone.
Status: RESOLVED → VERIFIED
status-firefox38: fixed → verified
Just verified across platforms using latest Aurora and Firefox 36 beta 3 and the issues does not reproduce anymore.
status-firefox36: fixed → verified
status-firefox37: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: