Closed Bug 1103859 Opened 5 years ago Closed 5 years ago

Fix some -Wunused-variable warnings by replacing jsapi-tests' MOZ_ASSERTs with MOZ_RELEASE_ASSERTs

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As illuminated by these -Wunused-variable warnings, some jsapi-tests use MOZ_ASSERT, so they test nothing in release builds:

js/src/jsapi-tests/testJitGVN.cpp:86:18: warning: variable 'newOuter' set but not used [-Wunused-but-set-variable]
js/src/jsapi-tests/testJitGVN.cpp:87:18: warning: variable 'newExit' set but not used [-Wunused-but-set-variable]
js/src/jsapi-tests/testJitGVN.cpp:181:18: warning: variable 'newOuter' set but not used [-Wunused-but-set-variable]
js/src/jsapi-tests/testJitGVN.cpp:182:18: warning: variable 'newExit' set but not used [-Wunused-but-set-variable]
Attachment #8527495 - Flags: review?(jorendorff)
Comment on attachment 8527495 [details] [diff] [review]
js-test-asserts.patch

Review of attachment 8527495 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8527495 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/f6beecf60b09
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.