1103869 - Test failure 'Notification popup state has been opened' in /restartTests/testAddons_InstallAddonWithoutEULA/test1.js

Status: RESOLVED INVALID

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Andrei Eftimie]

Module:    testInstallAddonWithEULA
Test:      /restartTests/testAddons_InstallAddonWithoutEULA/test1.js    
Failure:   Notification popup state has been opened
Branches:  36
Platforms: OSX
Report:    http://mozmill-daily.blargon7.com/#/remote/report/4b004f9a9a3a5bc3aa0f3a07c111faa8

I wonder why this wasn't filed yet, since it's failing constantly for more than 1 week now. Maybe it was thought to be related or part of bug 1096178.

But we have a different regression date here.

Comment 1

[Andrei Eftimie]

Attachment: skip.patch

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Barbara is also constantly seeing this as she told me last week. Maybe she can help.

Comment 3

[Andrei Eftimie]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Barbara is also constantly seeing this as she told me last week. Maybe she
> can help.

I'm also reproducing this

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8527520 [details] [diff] [review]
skip.patch

Review of attachment 8527520 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/restartTests/manifest.ini
@@ +15,5 @@
>  disabled = Bug 732353 - Disable all Discovery Pane tests due to unpredictable web dependencies
>  [include:testDiscoveryPane_installPickOfMonthAddon/manifest.ini]
>  disabled = Bug 657492 - 'Pick of the Month' add-ons are only compatible with Release and Beta builds
>  [include:testAddons_InstallAddonWithoutEULA/manifest.ini]
> +skip-if = os == 'mac' = Bug 1103869 - Test failure 'Notification popup state has been opened'

I also see a failure on Windows for this test. Better we disable it completely and come up with a fix soonish.

Comment 5

[Andrei Eftimie]

Attachment: skip2.patch

Let us disable it completely then.

Comment 6

[Andrei Eftimie]

mc daily pushlog pretty big:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ab137ddd3746&tochange=7f0d92595432

Working on reducing it more.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

There is also a single failure for now on Windows.

Comment 8

[Andrei Eftimie]

Disabled:
https://hg.mozilla.org/qa/mozmill-tests/rev/64225bc4ae25 (default)

Inbound pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=30276610fd29&tochange=a05b5362429f

Might be bug 989947.
I'll check some fx-team builds to be sure.

Comment 9

[Andrei Eftimie]

Pushlog from fx-team:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=a3d02e44a476&tochange=6bb4109d3f5e

So confirmed bug 989947 as a regressor.

I'll check exactly what fails here.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like this should really be OS X only then. The failure on Windows might be a single fallout.

Comment 11

[Andrei Eftimie]

The symptoms seem to be the same as in bug 1096178. Once we attempt to close firefox the notification appears. The underlying issue seems to be caused by loss of focus on the main window (since we operate on a Modal Dialog), and Notifications are kept on hold until the window regains focus.

Comment 12

[Andrei Eftimie]

Gijs, with bug 989947 some of our tests are failing where we install addons that open a Modal Dialog on OSX because the Notification Panel will not open (probably because we just operated on a Modal Dialog).

Is there any way to restore focus on the main window in a way that would make the Notification Panel appear? I've tried simple things like calling focus on the window, but that seems to have no effect.

Once we start the shutdown procedure (after the test finished) the Notification opens.

Comment 13

[:Gijs (he/him)]

(In reply to Andrei Eftimie from comment #12)
> Gijs, with bug 989947 some of our tests are failing where we install addons
> that open a Modal Dialog on OSX because the Notification Panel will not open
> (probably because we just operated on a Modal Dialog).
> 
> Is there any way to restore focus on the main window in a way that would
> make the Notification Panel appear? I've tried simple things like calling
> focus on the window, but that seems to have no effect.

No, popups won't open until the modal dialog goes away again.

Comment 14

[Andrei Eftimie]

(In reply to :Gijs Kruitbosch from comment #13) 
> No, popups won't open until the modal dialog goes away again.

We do close the modal dialog.

Comment 15

[:Gijs (he/him)]

(In reply to Andrei Eftimie from comment #14)
> (In reply to :Gijs Kruitbosch from comment #13) 
> > No, popups won't open until the modal dialog goes away again.
> 
> We do close the modal dialog.

Sure, but at that point you'll need to reopen the popup yourself. You can listen for the event added in bug 989947 to see when there are no more modal dialogs open so you can reopen the popup. The patches there should also give you an idea on how to determine the popup wasn't opened because of a modal dialog.

Comment 16

[Teodor Druta]

Another failure on Fx 35.0 RC lij locale on Ubuntu 14.04 x86
http://mozmill-release.blargon7.com/#/remote/report/b286a409cd8303a08379842fe4335692

Comment 17

[Daniela Domnici]

Attachment: testcase

The problem of this test is that for the OSX platform, the restart notification popup appears after a couple of seconds when we click on the install-button(when we close the browser),and for Ubuntu platform the restart notification popup appears after clicking the install-button.
I have created a testcase: removed the required modules(to eliminate the possibility that the bug be in library).

Comment 18

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8551776 [details] [diff] [review]
testcase

Review of attachment 8551776 [details] [diff] [review]:
-----------------------------------------------------------------

The testcases don't need to be patches, as we don't apply them on the repo. It has to be independent, that's why we use no lib imports. So please only add the testcase file, which should be able to run independently of the repo, just by running mozmill -t testcase.js (no matter where it is located) -b build.

Also add feedback request for myself and Henrik. Thanks!

Comment 19

[Daniela Domnici]

Attachment: testcase.js

Created the testcase : removed the required modules(to eliminate the possibility that the bug might be in the library).
It can be run independently of the repository.

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I don't see why we need another testcase here given that this bug is blocked by bug 1107405. It should have been marked as such.

Comment 21

[Daniela Domnici]

I talked to Cosmin, and he proposed a fix in the firefox bug 1107405, and in comment 5 (https://bugzilla.mozilla.org/show_bug.cgi?id=1107405#c5) he tested the fix agains this test on osx. The issue wasn’t the same so the fix didn’t help, that’s when he removed the dependency for this bug. So we think is another issue here, as the firefox bug it’s on all platforms and this test fails only on osx.

Comment 22

[Andreea Matei [:AndreeaMatei]]

Disabled this on release too, too many failures:
https://hg.mozilla.org/qa/mozmill-tests/rev/c5ded6fcdf4b (release)

Comment 23

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: patch v1.0

I explained the fix in bug 1096178 comment 28
Report:
http://mozmill-crowd.blargon7.com/#/remote/report/c922e10f6ac9f80d9cffdca9cf2d15ef

Comment 24

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8558500 [details] [diff] [review]
patch v1.0

Review of attachment 8558500 [details] [diff] [review]:
-----------------------------------------------------------------

This tested well:
https://hg.mozilla.org/qa/mozmill-tests/rev/eb484c9a3b28 (default)

Comment 25

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozmill tests have been superseded by Marionette tests.