Remove explicit type checking from Wait class

RESOLVED FIXED in mozilla36

Status

Testing
Marionette
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

unspecified
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The Wait class currently waits until the condition explicitly returns a False boolean value. As discussed in bug 1097032 we should change this to simply check for a falsy value.
(Assignee)

Comment 1

3 years ago
Created attachment 8527649 [details] [diff] [review]
Remove explicit type check in Wait class. v1.0

Try:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5f9742f26d40
Assignee: nobody → dave.hunt
Status: NEW → ASSIGNED
Attachment #8527649 - Flags: review?(ato)
(Assignee)

Updated

3 years ago
Blocks: 1097032
Comment on attachment 8527649 [details] [diff] [review]
Remove explicit type check in Wait class. v1.0

Review of attachment 8527649 [details] [diff] [review]:
-----------------------------------------------------------------

Results from try look surprisingly good!  Crossing my fingers this will work. (-:
Attachment #8527649 - Flags: review?(ato) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1dca3cd59b4
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a1dca3cd59b4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.