Closed Bug 1103956 Opened 8 years ago Closed 8 years ago

Remove explicit type checking from Wait class

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: davehunt, Assigned: davehunt)

References

Details

Attachments

(1 file)

The Wait class currently waits until the condition explicitly returns a False boolean value. As discussed in bug 1097032 we should change this to simply check for a falsy value.
Blocks: 1097032
Comment on attachment 8527649 [details] [diff] [review]
Remove explicit type check in Wait class. v1.0

Review of attachment 8527649 [details] [diff] [review]:
-----------------------------------------------------------------

Results from try look surprisingly good!  Crossing my fingers this will work. (-:
Attachment #8527649 - Flags: review?(ato) → review+
https://hg.mozilla.org/mozilla-central/rev/a1dca3cd59b4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.