Closed
Bug 1103978
Opened 10 years ago
Closed 10 years ago
aNewValue=undefined in onItemChange for removed keyword
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
People
(Reporter: asaf, Assigned: asaf)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
5.27 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
For removing a keyword from a bookmark, the new API expects update to be called with an empty string keyword value, rather than null. The empty string is then stored in the DB. This makes the old API (getKeywordForBookmark) and maybe also the new API (fetch, I didn't test) return different values for keyword-less bookmarks, depending on whether they have ever had a keyword (an empty string returned if they did; null if they didn't). This breaks the test for the EditKeyword transaction if it's converted to use the update API.
Flags: firefox-backlog+
|
||
Updated•10 years ago
|
Flags: qe-verify?
|
||
Updated•10 years ago
|
Flags: qe-verify?
Flags: qe-verify-
Flags: in-testsuite?
|
Assignee | |
Updated•10 years ago
|
Summary: Removing a keyword sets it to an empty string → aNewValue=undefined in onItemChange for removed keyword
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Updated•10 years ago
|
Iteration: --- → 37.1
|
|
||
Updated•10 years ago
|
Attachment #8528390 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/0c112347e322
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/0c112347e322 https://hg.mozilla.org/integration/fx-team/rev/b8d490a607e7
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0c112347e322 https://hg.mozilla.org/mozilla-central/rev/b8d490a607e7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•