aNewValue=undefined in onItemChange for removed keyword

RESOLVED FIXED in mozilla36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

(Blocks: 1 bug)

unspecified
mozilla36
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

For removing a keyword from a bookmark, the new API expects update to be called with an empty string keyword value, rather than null. The empty string is then stored in the DB. This makes the old API (getKeywordForBookmark) and maybe also the new API (fetch, I didn't test) return different values for keyword-less bookmarks, depending on whether they have ever had a keyword (an empty string returned if they did; null if they didn't).

This breaks the test for the EditKeyword transaction if it's converted to use the update API.
Flags: firefox-backlog+
Flags: qe-verify?

Updated

4 years ago
Flags: qe-verify?
Flags: qe-verify-
Flags: in-testsuite?
Summary: Removing a keyword sets it to an empty string → aNewValue=undefined in onItemChange for removed keyword
Created attachment 8528390 [details] [diff] [review]
patch
Assignee: nobody → mano
Status: NEW → ASSIGNED
Attachment #8528390 - Flags: review?(mak77)

Updated

4 years ago
Iteration: --- → 37.1

Updated

4 years ago
Attachment #8528390 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/0c112347e322
https://hg.mozilla.org/mozilla-central/rev/b8d490a607e7
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.