Closed
Bug 1103991
Opened 8 years ago
Closed 8 years ago
Stop building and shipping builds for Kurdish
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox34+ verified, firefox35+ verified, firefox36+ verified)
VERIFIED
FIXED
mozilla34
People
(Reporter: Pike, Assigned: Pike)
References
Details
Attachments
(1 file)
388 bytes,
patch
|
gueroJeff
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]: We have an incentive to stop Kurdish with 34, as the google plugin needs updates, and the locale isn't in a clean state. This bug is for all-locales and shipped-locales.
Assignee | ||
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8527651 [details] [diff] [review] remove Kurdish from all-locales and shipped-locales Review of attachment 8527651 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #8527651 -
Flags: review?(jbeatty) → review+
Comment 3•8 years ago
|
||
Please excuse my ignorance, why not remove it only from shipped-locales? Is there no hope that the locale comes back to a "clean state"? Or are all-locales and shipped-locales simply supposed to be in sync? My naive understanding is that having it in all-locales allows people to test and fix these builds without impairing what we ship...
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8527651 [details] [diff] [review] remove Kurdish from all-locales and shipped-locales Approval Request Comment [Feature/regressing bug #]: Unmaintained locale, the easiest way to fix google. [User impact if declined]: We'd be shipping a bad google plugin [Describe test coverage new/current, TBPL]: [Risks and why]: [String/UUID change made/needed]: None Also flagging lawrence for all the jazz of today. I can easily land myself, once poked. Note, this is best landed with DONTBUILD, too.
Flags: needinfo?(lmandel)
Attachment #8527651 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #3) > Please excuse my ignorance, why not remove it only from shipped-locales? Is > there no hope that the locale comes back to a "clean state"? Or are > all-locales and shipped-locales simply supposed to be in sync? My naive > understanding is that having it in all-locales allows people to test and fix > these builds without impairing what we ship... We have tried a few times to bring it back, and there's nobody in line to test and fix anything right now.
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8527651 [details] [diff] [review] remove Kurdish from all-locales and shipped-locales Approval Request Comment [Feature/regressing bug #]: We want this on both beta and aurora. Not needed on central [User impact if declined]: [Describe test coverage new/current, TBPL]: [Risks and why]: [String/UUID change made/needed]: None
Attachment #8527651 -
Flags: approval-mozilla-aurora?
Comment 7•8 years ago
|
||
Comment on attachment 8527651 [details] [diff] [review] remove Kurdish from all-locales and shipped-locales I look to l10n for guidance on the locales that are in a state to ship. I'm approving for Beta and Aurora based on Axel's assessment of this locale.
Flags: needinfo?(lmandel)
Attachment #8527651 -
Flags: approval-mozilla-beta?
Attachment #8527651 -
Flags: approval-mozilla-beta+
Attachment #8527651 -
Flags: approval-mozilla-aurora?
Attachment #8527651 -
Flags: approval-mozilla-aurora+
Updated•8 years ago
|
status-firefox35:
--- → affected
status-firefox36:
--- → affected
tracking-firefox35:
--- → +
tracking-firefox36:
--- → +
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/9b524ae83420 https://hg.mozilla.org/releases/mozilla-aurora/rev/5e0a0380350c I'd argue that 36 is not affected, for what it's worth.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Target Milestone: --- → Firefox 34
Updated•8 years ago
|
Flags: qe-verify+
Comment 9•8 years ago
|
||
I see that Kurdish builds are still built for Aurora/Developer edition, but not for Firefox 34 RC. From what I can understand ku builds should not be built for Firefox 34 (RC for now) and Firefox 35 (Aurora for now), or 35 is referring to beta builds?
Flags: needinfo?(l10n)
Assignee | ||
Comment 10•8 years ago
|
||
Yes, filed bug 1105224 to update buildbot-configs to stop the generation of the nightly builds.
Flags: needinfo?(l10n)
Updated•8 years ago
|
Comment 11•8 years ago
|
||
I haven`t seen 'ku' builds for 35beta and for Aurora as well since bug 1105224 was fixed (2014-11-26). Marking this as verified for Firefox 36 and closing the bug as well.
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
Updated•4 years ago
|
Target Milestone: Firefox 34 → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•