Closed Bug 1103996 Opened 10 years ago Closed 10 years ago

[Room][Notifications] Create 'room notifications' channel helper

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: borjasalguero, Assigned: borjasalguero)

References

Details

Attachments

(1 file)

Pull Request
61 bytes, text/x-github-pull-request
jaoo
: review+
jaoo
: feedback+
Details | Review 
We need a handler in order to listen and handle all events coming from the server related with Rooms. We will be listening and we should offer an interface in order to subscribe to all possible events from outside of the module.
Blocks: 1097760
Assignee: nobody → borja.bugzilla
Attached file Pull Request — 

        Attachment #8527800 -
        Flags: review?(josea.olivera)

    
    

    
  
Comment on attachment 8527800 [details] [review]
Pull Request

Looking really good. Have a look at the PR please. Request review at me again once everything gets addressed please. Thanks!

        Attachment #8527800 -
        Flags: review?(josea.olivera) → feedback+

    
  

        Attachment #8527800 -
        Flags: review?(josea.olivera)

    
    

    
  
Comment on attachment 8527800 [details] [review]
Pull Request

LGTM. r=me

Still a comment on the PR. Please address it and land at will. Tested a it works fine. Important change but nothing gets broken. Thanks for taking care of it!

        Attachment #8527800 -
        Flags: review?(josea.olivera) → review+

    
  
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: