[Room][Notifications] Create 'room notifications' channel helper

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: borjasalguero, Assigned: borjasalguero)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We need a handler in order to listen and handle all events coming from the server related with Rooms. We will be listening and we should offer an interface in order to subscribe to all possible events from outside of the module.
(Assignee)

Updated

3 years ago
Blocks: 1097760
(Assignee)

Updated

3 years ago
Assignee: nobody → borja.bugzilla
(Assignee)

Comment 1

3 years ago
Created attachment 8527800 [details] [review]
Pull Request
Attachment #8527800 - Flags: review?(josea.olivera)
Comment on attachment 8527800 [details] [review]
Pull Request

Looking really good. Have a look at the PR please. Request review at me again once everything gets addressed please. Thanks!
Attachment #8527800 - Flags: review?(josea.olivera) → feedback+
(Assignee)

Updated

3 years ago
Attachment #8527800 - Flags: review?(josea.olivera)
Comment on attachment 8527800 [details] [review]
Pull Request

LGTM. r=me

Still a comment on the PR. Please address it and land at will. Tested a it works fine. Important change but nothing gets broken. Thanks for taking care of it!
Attachment #8527800 - Flags: review?(josea.olivera) → review+
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.