1104061 - Bug in current Snippet Target URL (4758)

Status: VERIFIED FIXED

(Snippets :: Campaign, task)

Description

[Adam Lofting (:adamlofting)]

Attachment: Screen Shot 2014-11-24 at 14.59.42.png

I'm not sure who is building / setting these up, so please assign as needed :)

---

I'm looking at the traffic coming in from Snippet 4578 (which on the whole is performing really really well) but there's an issue with the target URL. (https://snippets.mozilla.com/show/4758/)

If the user selects one of the donation amount buttons, the target URL loses the snippet_name parameter which makes it harder to analyse which snippet is sending traffic when we're looking at the data in Google Analytics.

--

If the user doesn't select an amount and just click the donate now button, they end up here: 

  https://sendto.mozilla.org/page/contribute/givenow-1page?ref=EOYFR2014&utm_campaign=EOYFR2014&utm_source=firefox&utm_medium=snippet&utm_content=SelectAMT_test1&sample_rate=0.1&snippet_name=4758#amount-10

which has the 'snippet_name=4758' in the URL

But if the do select an amount, they get a URL like this instead:

  https://sendto.mozilla.org/page/contribute/givenow-1page?ref=EOYFR2014&utm_campaign=EOYFR2014&utm_source=firefox&utm_medium=snippet&utm_content=SelectAMT_test1#amount-5

--

They end up as two seperate rows in GA. Which will get confusing when we have multiple snippets running in parallel.

Comment 1

[Osmose [:osmose, :mkelly]]

Attachment: Pull request

Put up a pull request with a fix that ensures the snippet_name parameter stays.

Comment 2

[Osmose [:osmose, :mkelly]]

Tested on Firefox 34 and 26 (It's a pretty low-risk change) and it works fine. Template has been updated on prod.

adamlofting: It'll take 24 hours for every user to get the updated template, but within a few hours you should start to see the numbers for URLs with the snippet_name URL on other donation amounts to jump. Can you mark this as verified once you confirm that you're seeing the parameter show up?

Also, I just realized that we only added the snippet ID back in, the sample rate is still missing (and adding it in would be non-trivial). That means the URL will still be different for people who just directly click donate vs people who click a donation amount first. Is that okay? (I'd assume you could still filter on the snippet_name parameter rather than by unique URLs).

Comment 3

[Adam Lofting (:adamlofting)]

Thanks for fixing this so quickly. I can confirm the users picking up the new template are now showing up in GA. 

(In reply to Michael Kelly [:mkelly,:Osmose] from comment #2)
> Also, I just realized that we only added the snippet ID back in, the sample
> rate is still missing (and adding it in would be non-trivial). That means
> the URL will still be different for people who just directly click donate vs
> people who click a donation amount first. Is that okay? (I'd assume you
> could still filter on the snippet_name parameter rather than by unique URLs).

That's absolutely fine, I can still filter on that. Thanks.

Comment 4

[Osmose [:osmose, :mkelly]]

Verified as per comment 3. :D