1104062 - Optimize or remove thCloneJobs.resetCounts

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Mauro Doglio [:mdoglio]]

According to the profiler this function is very expensive in terms of cpu. I'm not sure what its purpose is. After commenting this function I was able to load 120 pushes without getting the unresponsive script dialog.

Comment 1

[Cameron Dawson [:camd]]

Looking at resetCounts(), it appears that we walk over ALL resultsets for EACH resultset.  So that is a multiplier that's in incredible waste of time.  This may not be the ONLY inefficiency, but it's one of them.

Comment 2

[Cameron Dawson [:camd]]

This PR changes the ``resetCounts`` function to operate on only a single ``resultset`` rather than ALL resultsets in the ``resultSetMap``.  And that function is now only called once per resultset after all the platforms have been updated.

Previously, this function was called on ALL ``resultsets`` each time a ``platform`` within a ``resultset`` was updated.  10 resultsets X 30 platforms = 3000 calls.  As you loaded more ``resultsets``, this was compounded.

Now this is called once for a resultset only when that resultset is updated (or initially loaded).

Comment 3

[Cameron Dawson [:camd]]

Attachment: ui PR

Comment 4

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/9ed0ab43b59043e7bbc33a802fc8c1b92c3892f6
Bug 1104062 - only update counts once per resultset on changes

https://github.com/mozilla/treeherder-ui/commit/89b6362bd0c378cac26ed87071889d6ea9c10957
Merge pull request #299 from mozilla/optimize-resetcounts

Bug 1104062 - only update counts once per resultset on changes

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/57c6318cece400d4a6414de157c7b1ab6db9381e
Bug 1104062 - only update counts once per resultset on changes

https://github.com/mozilla/treeherder/commit/dd31025b8cca9121a17a6c07f24c89c735dc0871
Merge pull request #299 from mozilla/optimize-resetcounts

Bug 1104062 - only update counts once per resultset on changes