[Usage] Formatting.js can be unavailable at the moment when 'timeformatchange' event is fired

RESOLVED WONTFIX

Status

--
trivial
RESOLVED WONTFIX
4 years ago
9 months ago

People

(Reporter: azasypkin, Unassigned)

Tracking

({papercut})

Firefox Tracking Flags

(Not tracked)

Details

In settings.js [1] we subscribe for 'timeformatchange' event and only then lazily load js files that both fire this event (by date_time_helper.js) and handle it (formatting.js). So in Mulet\Nightly where everything is pretty fast due to mocked API, 'timeformatchange' is fired and handled before "formatting.js" is actually loaded.

The easiest fix that comes in mind is to just keep right order for lazy loading (formatting.js -> date_time_helper.js) [2]. 

This issue is quite minor since there is almost no chance that it'll happen on device.

[1] https://github.com/mozilla-b2g/gaia/blob/7387e3f418b957ff27067c05f69afeaa6dab35ae/apps/costcontrol/js/settings/settings.js#L371

[2] https://github.com/mozilla-b2g/gaia/blob/7387e3f418b957ff27067c05f69afeaa6dab35ae/apps/costcontrol/js/settings/settings.js#L381

Comment 1

9 months ago
Firefox OS is not being worked on
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.