Closed Bug 1104094 Opened 8 years ago Closed 8 years ago

[l10n] Inspector's paste HTML label corrections

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 36

People

(Reporter: pbro, Assigned: fayolle-florent)

Details

Attachments

(1 file)

1104094.patch
968 bytes, patch
pbro
: review+
Details | Diff | Splinter Review 
From https://bugzilla.mozilla.org/show_bug.cgi?id=1095521#c22 :

> As usual, you shouldn't use "..." but "…". Also, the space before makes no
> sense
> 
> <!ENTITY inspectorHTMLPasteExtraSubmenu.label      "Paste ...">
> <!ENTITY inspectorHTMLPasteExtraSubmenu.accesskey  "T">
> 
> And since the available character is "t" in the label, I would use lowercase
> (not that it fails, it's just cleaner).
Attached patch 1104094.patch — — Splinter Review 
Voilà!

Florent
Attachment #8527820 - Flags: review?(pbrosset)
Comment on attachment 8527820 [details] [diff] [review]
1104094.patch

Review of attachment 8527820 [details] [diff] [review]:
-----------------------------------------------------------------

(note for reviewer: no need to update the string ID for these cases)
Comment on attachment 8527820 [details] [diff] [review]
1104094.patch

Review of attachment 8527820 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Florent for working on this quickly.
Attachment #8527820 - Flags: review?(pbrosset) → review+
Checkin-needed without a try push since this is a string change from "Paste ..." to "Paste…"
Keywords: checkin-needed
Assignee: nobody → fayolle-florent
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/82518db4042c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.