Open Bug 1104141 Opened 10 years ago Updated 2 years ago

Deleting "Visit XYZ" doesn't delete the History-entry

Categories

(Firefox :: Address Bar, defect, P5)

x86_64
Windows 7
defect
Points:
3

Tracking

()

People

(Reporter: elbart, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [fxsearch])

- Type a domain you haven't visited before, i.e geise.de, and hit enter.
- Close the tab and open a new one.
- Type "geise.de", press down-arrow and hit delete to remove the "Visit"-entry
- Open the history and search for geise.de

ER:
geise.de should be gone.

AR:
geise.de is still there.

Before unifiedautocomplete, or with UA disabled, the selected entry was deleted from the history when hitting delete in the awesomebar-results-pane.
this happens for a UI glitch, the first entry is different than the others, it doesn't support history removal.
fwiw removals are a not very discoverable option, so this is not going to block the feature. we plan a redesign that could address the issue by showing a visual removal option (or a context menu)
Blocks: 1071461
No longer blocks: UnifiedComplete
(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #1)
> this happens for a UI glitch, the first entry is different than the others,
> it doesn't support history removal.

I understand.

Maybe showing the normal result below the "Visit"-option would work too.
Currently, only the "Visit"-option is shown.
See Also: → 636992
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P5
Component: Places → Location Bar
Product: Toolkit → Firefox
Whiteboard: [fxsearch]

The Quantum Bar does the right thing allowing to only remove certain entries, so it is less confusing, I think the only remaining thing here is to make this discoverable... for which we likely want something like bug 1041761. At that point we could also expose a "Forget about this site" option.

Depends on: 1041761
See Also: → 1269505
Points: --- → 3

From https://bugzilla.mozilla.org/show_bug.cgi?id=1675552 :

Hitting (shift +) delete I expect the suggestion to vanish. No matter where it is stored. Until manually visited again.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.