110424 - Charset menu in tabbed browser mode are not right

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Frank Tang]

1. bring up severl tab by click Ctrl+ t
2. in one tab, type http://home.netscape.com/ja
3. check the charset menu, it said "Japanese (Shift-JIS)", which is correct
4. in another tab, type http://www.yahoo.co.jp
5. look at the charset menu again, it said "Japanese (EUC-JP)" which is still
correct
6. click back to the first tab, check the charset menu, it said "Japanese
(EUC-JP)", instead of "Japanese (Shift-JIS)"

Expect result, while user select different tab, the charset menu reflect the
charset of the selected tab.

Comment 1

[nhottanscp]

*** Bug 111217 has been marked as a duplicate of this bug. ***

Comment 2

[nhottanscp]

The current code is hooked up to the document load (so reloading corrects the 
check mark).
I need to hook up the code to update the checkmark for tab switch.

Comment 3

[nhottanscp]

Attachment: Added code to update charset at tab switch.

Comment 4

[Alec Flett]

Comment on attachment 60822 [details] [diff] [review]
Added code to update charset at tab switch.

seems quite reasonable. I agree that saving the last charset in tabbrowser.xml
would be strange. I guess what tabbrowser.xml really needs is a global state
object that gets passed in  when it is initialize. This will do though.

sr=alecf

Comment 5

[David Hyatt]

I don't understand why the tab browser code has to be touched here.  Can't you 
just grab this information dynamically when the charset menu is opened?

Comment 6

[nhottanscp]

I guess you are right. I think the cache was introduced to improve for loading,
the menu handling code does not have to depend on that value.

Comment 7

[nhottanscp]

Attachment: Changed not to use the cached value in the checkmark update code. The cache is needed for the load listener, using it in the checkmark code will cause the inconsistency for tab browser.

Comment 8

[nhottanscp]

got review by ftang

Comment 9

[Frank Tang]

Comment on attachment 61150 [details] [diff] [review]
Changed not to use the cached value in the checkmark update code. The cache is needed for the load listener, using it in the checkmark code will cause the inconsistency for tab browser.

r=ftang

Comment 10

[Alec Flett]

Comment on attachment 61150 [details] [diff] [review]
Changed not to use the cached value in the checkmark update code. The cache is needed for the load listener, using it in the checkmark code will cause the inconsistency for tab browser.

hah, well that's easy enough.
sr=alecf

Comment 11

[nhottanscp]

checked in

Comment 12

[Teruko Kobayashi]

Verified as fixed in 12-28 trunk build.