Charset menu in tabbed browser mode are not right

VERIFIED FIXED in mozilla0.9.7

Status

()

VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: ftang, Assigned: nhottanscp)

Tracking

({intl})

Trunk
mozilla0.9.7
x86
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

17 years ago
1. bring up severl tab by click Ctrl+ t
2. in one tab, type http://home.netscape.com/ja
3. check the charset menu, it said "Japanese (Shift-JIS)", which is correct
4. in another tab, type http://www.yahoo.co.jp
5. look at the charset menu again, it said "Japanese (EUC-JP)" which is still
correct
6. click back to the first tab, check the charset menu, it said "Japanese
(EUC-JP)", instead of "Japanese (Shift-JIS)"

Expect result, while user select different tab, the charset menu reflect the
charset of the selected tab.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Summary: Charset menu in tabbed brwoser mode are not right → Charset menu in tabbed browser mode are not right
Target Milestone: --- → mozilla0.9.7
(Assignee)

Comment 1

17 years ago
*** Bug 111217 has been marked as a duplicate of this bug. ***

Updated

17 years ago
Keywords: intl, nsbeta1
(Assignee)

Comment 2

17 years ago
The current code is hooked up to the document load (so reloading corrects the 
check mark).
I need to hook up the code to update the checkmark for tab switch.
(Assignee)

Comment 3

17 years ago
Created attachment 60822 [details] [diff] [review]
Added code to update charset at tab switch.

Comment 4

17 years ago
Comment on attachment 60822 [details] [diff] [review]
Added code to update charset at tab switch.

seems quite reasonable. I agree that saving the last charset in tabbrowser.xml
would be strange. I guess what tabbrowser.xml really needs is a global state
object that gets passed in  when it is initialize. This will do though.

sr=alecf
Attachment #60822 - Flags: superreview+

Comment 5

17 years ago
I don't understand why the tab browser code has to be touched here.  Can't you 
just grab this information dynamically when the charset menu is opened?
(Assignee)

Comment 6

17 years ago
I guess you are right. I think the cache was introduced to improve for loading,
the menu handling code does not have to depend on that value.
(Assignee)

Comment 7

17 years ago
Created attachment 61150 [details] [diff] [review]
Changed not to use the cached value in the checkmark update code. The cache is needed for the load listener, using it in the checkmark code will cause the inconsistency for tab browser.
Attachment #60822 - Attachment is obsolete: true
(Assignee)

Comment 8

17 years ago
got review by ftang
(Reporter)

Updated

17 years ago
Attachment #61150 - Flags: review+
(Reporter)

Comment 9

17 years ago
Comment on attachment 61150 [details] [diff] [review]
Changed not to use the cached value in the checkmark update code. The cache is needed for the load listener, using it in the checkmark code will cause the inconsistency for tab browser.

r=ftang

Comment 10

17 years ago
Comment on attachment 61150 [details] [diff] [review]
Changed not to use the cached value in the checkmark update code. The cache is needed for the load listener, using it in the checkmark code will cause the inconsistency for tab browser.

hah, well that's easy enough.
sr=alecf
Attachment #61150 - Flags: superreview+
(Assignee)

Comment 11

17 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 12

17 years ago
Verified as fixed in 12-28 trunk build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.