Closed Bug 1104271 Opened 6 years ago Closed 6 years ago

There is no logger reference in the GaiaTestCase object

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: njpark, Assigned: davehunt)

Details

(Whiteboard: [affects=gaia])

Attachments

(1 file)

it appears that we have a logger reference in the runner but not the tests.

Currently, the way to instantiate the logger for GaiaTestCase is to do:
from mozlog.structured import get_default_logger
self.logger = get_default_logger()
Malini: Do you think it makes sense to simply pass self.logger when adding tests to the suite and then pop it from kwargs in CommonTestCase?
Flags: needinfo?(mdas)
Yup, that should be fine
Flags: needinfo?(mdas)
Whiteboard: [affects=gaia]
Comment on attachment 8533735 [details] [diff] [review]
Provide a logger for Marionette test cases. v1.0

Review of attachment 8533735 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm thanks!
Attachment #8533735 - Flags: review?(mdas) → review+
https://hg.mozilla.org/mozilla-central/rev/cb1647232cf4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.