1104271 - There is no logger reference in the GaiaTestCase object

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[No-Jun Park [:njpark]]

it appears that we have a logger reference in the runner but not the tests.

Currently, the way to instantiate the logger for GaiaTestCase is to do:
from mozlog.structured import get_default_logger
self.logger = get_default_logger()

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Malini: Do you think it makes sense to simply pass self.logger when adding tests to the suite and then pop it from kwargs in CommonTestCase?

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Yup, that should be fine

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Provide a logger for Marionette test cases. v1.0

Try:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5cb5ae642ecc

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8533735 [details] [diff] [review]
Provide a logger for Marionette test cases. v1.0

Review of attachment 8533735 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm thanks!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/cb1647232cf4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cb1647232cf4