If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Build functionality to deliver snippets based on search provider

RESOLVED FIXED

Status

Snippets
Service
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ckprice, Assigned: giorgos)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8527967 [details]
New snippet field

# Overview

Update snippets admin to exclude users based on their search provider.

# Specification

Create a new field to exclude search providers (see attached for mockup).

The service will then check the search provider using the Mozilla.UITour.getConfiguration function[1], and show/hide the snippet based on the setting.

# Due date

Snippet will launch on 12/15/2014, so we'd like to have the service tested and ready by 12/12.


[1] New UITour search functions: https://etherpad.mozilla.org/uitour-ff34
Note: we will launch with just Yahoo! as a selectable search provider. We will add more in the future, so this should be something we can easily maintain.

:giorgos - is this something you can get done by 12/10?

:Osmose can be available for any review or questions.
Flags: needinfo?(giorgos)
(Assignee)

Comment 2

3 years ago
I'll give a try right now.
Flags: needinfo?(giorgos)
(Assignee)

Updated

3 years ago
Assignee: nobody → giorgos
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
I added Google and Bing as well because it was easy and I needed it for testing anyway. Hope that's not a problem! :)

PR https://github.com/mozilla/snippets-service/pull/87

Comment 4

3 years ago
Commits pushed to master at https://github.com/mozilla/snippets-service

https://github.com/mozilla/snippets-service/commit/1e526f28620c48d28b141a4960b3825ec57c79a2
[fix bug 1104336] Add option to exclude search engines.

https://github.com/mozilla/snippets-service/commit/675f8e1cce344256a4f97a8ec96e1b077fada46b
Merge pull request #88 from glogiotatidis/search-filtering2

[fix bug 1104336] Add option to exclude search engines.

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

3 years ago
This is now on production. Search providers can be added/edited/removed from /admin. Currently Yahoo!, Bing and Google are available.

Comment 6

3 years ago
Looks good, thank you!!

Do I need to add any client rules when running these snippets?
Flags: needinfo?(giorgos)
(Assignee)

Comment 7

3 years ago
We can read the preferred search engine starting from firefox 34.0. On older foxes we cannot know which engine the user is using and therefore we are not making any filtering based on that. All snippets will be displayed on version <34.0.

If you want to avoid displaying all snippets on older versions, yes you need to use a client match rule to exclude them. Not doing so, will not break anything, it will just show all snippets.

If you want the rule I can create it for you.
Flags: needinfo?(giorgos)
You need to log in before you can comment on or make changes to this bug.