110437 - offline-mode menu item does't work from mail-windows

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[tabit]

I use the nightly built: 

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.5+) Gecko/20011114

today I noticed that the offline-mode is not accessible from mail-windows, but
only from browser-windows. However: If I go to offline-mode in the
browser-window, the mail-windows will switch to offline-mode too.

Comment 1

[David :Bienvenu]

It looks available to me - the offline icon is in the lower right corner of the
3 pane mail window and it works fine. The menu item is also available and works.
Could you be more specific about what "not accessible" means? thx.

Comment 2

[tabit]

The "menu-item" is there but does not work. Normally when I chose "offline" in
mail&news mozilla asked me if i wanted to download  mail&news before I go
offline or not. Now nothing happens. But when I go to a
browser-window-"menu-item" and choose "offline", all menu-items in all windows
change from "work offline" to "work online".

regards

Comment 3

[David :Bienvenu]

yep, you're right, the menu item is broken. Sigh, I wonder who broke it...

Comment 4

[grylchan]

dang. I guess I need to use menu item more often. Sorry didn't catch this.
It's been broken for a while.

Using mac 9.1 trunk builds:
 it worked in 10-22-15 trunk build
 it doesn't work in 10-23-08-trunk build.

Comment 5

[David :Bienvenu]

hey Gary, thanks for narrowing it down. I'll go look at the hook for that day.

Comment 6

[grylchan]

yup definitly that time line.
For windows
 works in 2001-10-22-13-trunk/
 broken in 2001-10-23-11-trunk/ 

Comment 7

[grylchan]

Cvs query link between dates:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&bra
nchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&d
ate=explicit&mindate=10%2F22%2F2001+13%3A59%3A00&maxdate=10%2F23%2F2001+12%3A08%
3A00&cvsroot=%2Fcvsroot

Comment 8

[Dimitrios]

Hmm, it seems that bug 110086 is depended on this.

Comment 9

[David :Bienvenu]

this is a weird one - it's a problem with the js/xul, somehow.  We're supposed
to just get this for free, but somehow we're not getting the right stuff from
the utilityOverlay.xul - my guess is that this was broken by someone changing
something about include order or something. I guess I'll just have to keep
poking at it with a stick.

Comment 10

[David :Bienvenu]

Attachment: explictly define offline menu

I don't know how it worked before, or why it stopped working, but explictly
adding this menu item does work. We also do correctly change the menu item when
we go offline from the browser. Asking for reviews from JF and Seth

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: alternate patch, not sure what's going on either.

Comment 12

[(not reading, please use [e-mail] instead)]

cc blake for review. 

he usually knows what's going on with problems like these.

Comment 13

[(not reading, please use [e-mail] instead)]

taking, and moving to 0.9.8.

Comment 14

[(not reading, please use [e-mail] instead)]

fixed.

Comment 15

[grylchan]

Using commercial trunk builds:
2002010203 on NT 4.0
2002010208 on linux 2.2 and mac 9.1
2002010212 on mac os 10.1

In both themes, Verified offline menu item works as expected
and displays the correct text (work online or work offline)
when going offline in different ways.

Tested
  1. going offline/online via messenger menu item
  2. going offline via offline icon and online via messenger menu item
  3. going offline via messenger menu item and online via offline icon
  4. going off/on line via offline icon 
  5. going off/on via browser menu
  6. going off via browser menu and on via messenger menu
  7. going off via messenger menu and online via browser menu
  8. different combinations of using offline icon and browser menu item
  9. also tested going offline via icon in seperate mesg window

marking as verified

Comment 16

[grylchan]

*** Bug 118518 has been marked as a duplicate of this bug. ***