Remove repository visualizer code from pushlog

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: gps, Unassigned)

Tracking

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/4208] )

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
The pushlog hgweb code has a feature for visualizing repositories. See https://hg.mozilla.org/hgcustom/version-control-tools/file/d340711f1e5a/hgext/pushlog-legacy/www

AFAICT all this code came from bsmedberg during a coding spree on March 25, 2008 and again on April 14, 2008. This code appears to be not used. Furthermore, it doesn't work with modern versions of Mercurial.

As cool as this feature looks, it looks completely dead and is currently only making the code more complicated. I propose nuking it.

If we want to bring back a repository visualizer, the code is there in history for us to look at.
(Reporter)

Comment 1

4 years ago
Created attachment 8528058 [details]
MozReview Request: bz://1104390/gps
Attachment #8528058 - Flags: review?(benjamin)
(Reporter)

Comment 2

4 years ago
/r/975 - Bug 1104390 - Remove legacy web-based repository visualizer

Pull down this commit:

hg pull review -r 8a2bee58ffb72be1cf2e0a4f0f9987557ce8eeef
(Reporter)

Comment 3

4 years ago
/r/975 - Bug 1104390 - Remove legacy web-based repository visualizer

Pull down this commit:

hg pull review -r 1f53ff40ba125d40a29af4526f27ffe25f35e0d4
(Reporter)

Comment 4

4 years ago
https://reviewboard.mozilla.org/r/973/#review527

It looks like there are some hidden uses of hgwebjson.py. I'm going to keep that file around for the moment. It's time on the chopping block will come soon.
(Reporter)

Updated

4 years ago
Attachment #8528058 - Flags: review?(bkero)
(Reporter)

Comment 5

4 years ago
/r/975 - Bug 1104390 - Remove legacy web-based repository visualizer
/r/983 - Bug 1104390 - Remove unused JSON output commands from hgwebjson.py
/r/985 - Bug 1104390 - Remove printpushlog command
/r/987 - Bug 1104390 - Move hgwebjson into pushlog-feed.py

Pull down these commits:

hg pull review -r c49b174156308235bc44444aa05c9cbccae0c5a2
(Reporter)

Comment 6

4 years ago
https://reviewboard.mozilla.org/r/973/#review535

I guess I was wrong about these json endpoints not working: they do work. I was just trying to access them under e.g. /family (since that is the name of the web command). I forgot the hgweb dispatcher does some path munging. So the actual paths are things like /json-family. And these URLs *do* work. I'll need to audit the logs to see if anyone is using these.

Updated

4 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/4208]

Comment 7

4 years ago
https://reviewboard.mozilla.org/r/985/#review891

lgtm, if anybody complains we can add it back in

Updated

4 years ago
Attachment #8528058 - Flags: review?(benjamin)
(Reporter)

Comment 9

4 years ago
Auditing the server logs, json-info is heavily used. It looks like some consumer of the Firefox trees is polling the server for JSON info.

I dropped the removal of the hgwebjson code from the series and pushed the remaining 2 patches.

I'd still like to see this code die. But that can be put off until another day.
(Reporter)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(In reply to Gregory Szorc [:gps] from comment #9)
> Auditing the server logs, json-info is heavily used. It looks like some
> consumer of the Firefox trees is polling the server for JSON info.

I managed to find https://github.com/darchons/tbpl-heatmap/blob/master/fetch-data.js#L18

Though it's quite tied to TBPL currently, so will stop working once TBPL is EOLed.

Updated

3 years ago
Attachment #8528058 - Flags: review?(bkero) → review+
(Reporter)

Comment 11

3 years ago
Comment on attachment 8528058 [details]
MozReview Request: bz://1104390/gps
Attachment #8528058 - Attachment is obsolete: true
Attachment #8618714 - Flags: review+
Attachment #8618715 - Flags: review+
Attachment #8618716 - Flags: review+
Attachment #8618717 - Flags: review+
(Reporter)

Comment 12

3 years ago
Created attachment 8618714 [details]
MozReview Request: Bug 1104390 - Remove printpushlog command
(Reporter)

Comment 13

3 years ago
Created attachment 8618715 [details]
MozReview Request: Bug 1104390 - Move hgwebjson into pushlog-feed.py
(Reporter)

Comment 14

3 years ago
Created attachment 8618716 [details]
MozReview Request: Bug 1104390 - Remove unused JSON output commands from hgwebjson.py
(Reporter)

Comment 15

3 years ago
Created attachment 8618717 [details]
MozReview Request: Bug 1104390 - Remove legacy web-based repository visualizer
You need to log in before you can comment on or make changes to this bug.