110448 - javascript strict warnings in editor.js

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect, P3)

Description

[Henrik Gemal]

Warning: assignment to undeclared variable gPrefs
Source File: chrome://editor/content/editor.js
Line: 299

build 20011115

Comment 1

[Syd Logan]

Some steps to get to the error would be nice...

Comment 2

[Henrik Gemal]

looking at the code it seems to happen the first time that the composer it started.

gPrefs = GetPrefs();
should just be:
var gPrefs = GetPrefs();

at line 299 in editor.js

Comment 3

[Alex Vincent [:WeirdAl]]

I disagree.  For one, I cannot see this warning given the steps named.  For
another, take a look at line 74 of
http://lxr.mozilla.org/seamonkey/source/editor/ui/composer/content/editor.js .

var gPrefs;

Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+) Gecko/20020105

Reporter:  Have you been able to reproduce this strict JS warning in a recent build?

Comment 4

[Stephen Walker]

var gPrefs; on line 74 was added by cmanske with his 1.129 checkin on 11/29, so 
this bug should be fixed.

Comment 5

[Henrik Gemal]

This is the only warning I'm now seeing:

Warning: redeclaration of var element
Source File: chrome://editor/content/editor.js
Line: 961, Column: 8
Source Code:
var element;

http://lxr.mozilla.org/mozilla/source/editor/ui/composer/content/editor.js#961el
but element is already defined in:
http://lxr.mozilla.org/mozilla/source/editor/ui/composer/content/editor.js#936

Comment 6

[Alex Vincent [:WeirdAl]]

Attachment: patch for var element; redeclaration

Comment 7

[Alex Vincent [:WeirdAl]]

Adding patch keyword as I cannot check this in.  Note this is a completely safe
patch for 0.9.8, recommend getting a= from one of the drivers.

Comment 8

[Stephen Walker]

Comment on attachment 65232 [details] [diff] [review]
patch for var element; redeclaration

r=walk84

Comment 9

[Kathleen :Brade]

r=brade (module owner)

Comment 10

[Stephen Walker]

simon: can you sr= Alex's patch?

Comment 11

[kinmoz]

Looks like someone already checked in this fix.

Comment 12

[kinmoz]

Comment on attachment 65232 [details] [diff] [review]
patch for var element; redeclaration

sr=[e-mail]

Comment 13

[Alex Vincent [:WeirdAl]]

Last time I heard someone tell me the fix was already checked in, I reopened the
bug a week later.

It's now line 990.

Comment 14

[Kathleen :Brade]

yes, the problem is still present (notice Kin did add an sr=); I have this patch
in my tree and I hope to check it in soon (unless Daniel or someone else beats
me to it).

Comment 15

[Stephen Walker]

bz checked in the patch on Feb. 2

Comment 16

[sujay]

Henrik, please verify...thx.

Comment 17

[Henrik Gemal]

verified on 20020208