110456 - Warning icon in Reset Master Password dialog is stretched

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[Henrik Gemal]

In the Reset Master Password dialog the yellow icon seems to be streched so it 
looks really really stupid.

build 20011115

Comment 1

[Chris Brien]

Attachment: Screenshot

Probably related to bug 111372 and 108567

Comment 2

[Chris Brien]

Attachment: Fixed screenshot

I have a fix for this, as you can tell by the new screenshot. I'll create a
patch for it later tonight, and then I'll have to bother someone about getting
it in the tree.

Comment 3

[Chris Brien]

Attachment: Patch to resetpassword.xul

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 58988 [details] [diff] [review]
Patch to resetpassword.xul

r=bzbarsky

Comment 5

[Boris Zbarsky [:bzbarsky]]

mail blake and cc [e-mail] and ask for sr.  :)

Comment 6

[Stephane Saux]

Comment on attachment 58988 [details] [diff] [review]
Patch to resetpassword.xul

Technically this needs
r= from module owner, the
PSM team.
r=ssaux

Comment 7

[John Unruh]

nsbeta1

Comment 8

[Stephane Saux]

we'll plus is if we get sr

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Has anyone mailed for sr, yet?  This fix is simple, and it's an ugly sight to see.

Comment 10

[Chris Brien]

ok, this bug is stagnating.

1) Does this still happen
2) Does the patch still fix it?
3) If 1) && 2), why isnt this in the tree yet?

Comment 11

[Boris Zbarsky [:bzbarsky]]

1) Yes
2) Yes
3) Because the patch never got a super-review.  See
   http://mozilla.org/hacking/reviewers.html and comment 5...

I have mailed another sr request in the hopes that it will actually get sr'ed
this time...

Comment 12

[Boris Zbarsky [:bzbarsky]]

taking this so it stays on my radar...

Comment 13

[Alec Flett]

Comment on attachment 58988 [details] [diff] [review]
Patch to resetpassword.xul

sr=alecf

Comment 14

[Boris Zbarsky [:bzbarsky]]

checked in on the trunk.  I don't think this'd make branch, so I'm not going to
ask for approval, but if I'm missing something and this is critical for branch,
please let me know and I'll mail drivers.

Comment 15

[John Unruh]

Verified on 6/26 Win2000 trunk.

Comment 16

[John Unruh]

Verified.