Closed
Bug 1104597
Opened 10 years ago
Closed 9 years ago
build libcurl from partner code
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S2 (19dec)
People
(Reporter: viralwang, Assigned: viralwang)
References
Details
Attachments
(1 file)
https://bugzilla.mozilla.org/show_bug.cgi?id=1103879#c2 We should build libcurl in our side instead of using extract-files.sh
Assignee | ||
Comment 1•10 years ago
|
||
Hi Michael, Could you please help to review this? I will request a mirrored build on git.m.o before landing. Thanks
Attachment #8528210 -
Flags: review?(mwu)
Comment 2•10 years ago
|
||
Comment on attachment 8528210 [details] [review] add external/curl in base-kk-caf.xml BTW, do you know what's using libcurl?
Attachment #8528210 -
Flags: review?(mwu) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Hi Michael, /system/bin/xtwifi-inet-agent will need this library root@flame:/ # ./system/bin/xtwifi-inet-agent CANNOT LINK EXECUTABLE: could not load library "libcurl.so" needed by "./system/bin/xtwifi-inet-agent"; caused by library "libcurl.so" not found
Comment 4•10 years ago
|
||
Can you make this base-kk-caf.xml only for now? I think dolphin builds might break otherwise. Go ahead and land if you see travis tests pass.
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8528210 [details] [review] add external/curl in base-kk-caf.xml move base-kk.xml to base-kk-caf.xml. also update reviewer in comment.
Attachment #8528210 -
Attachment description: add external/curl in base-kk.xml → add external/curl in base-kk-caf.xml
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
Master: https://github.com/mozilla-b2g/b2g-manifest/commit/b6bf19bad47cb4d25003b14a707ac045986013d3
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S2 (19dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•