1104655 - [gonk-l] toolkit/mozapps/update/updater get compile error

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Comment 1

[Ken Chang[:kenkai]]

Kai-Zhen, do you want to take this bug?

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-1104655-updater.patch

Michael, Could you review this patch? As without this patch there is a compile error.
--
gecko/toolkit/mozapps/update/updater/updater.cpp:2392: error: undefined reference to 'ioprio_set'
collect2: error: ld returned 1 exit status
make[3]: *** [updater] Error 1

Comment 3

[Kai-Zhen Li [:seinlin][:kli]]

Why I got this compile error is because I have 'export B2G_UPDATER=1' in .userconfig.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 8539642 [details] [diff] [review]
bug-1104655-updater.patch

Review of attachment 8539642 [details] [diff] [review]:
-----------------------------------------------------------------

Can you implement ioprio_set using syscall instead?

Comment 5

[Michael Wu [:mwu]]

Request review from rstrong when you have a new patch.

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-1104655.patch

Michael, I use syscall to set ioprio in this path. But ICS do not have the definition of SYS_ioprio_set so I add a checking for it. Could you review this patch? Thanks!

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c448932b9eeb

Comment 8

[Michael Wu [:mwu]]

Comment on attachment 8545613 [details] [diff] [review]
bug-1104655.patch

Review of attachment 8545613 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/updater/updater.cpp
@@ +2388,5 @@
>        if (setpriority(PRIO_PROCESS, 0, prioVal)) {
>          LOG(("setpriority(%d) failed, errno = %d", prioVal, errno));
>        }
> +      if (syscall(SYS_ioprio_set, IOPRIO_WHO_PROCESS, 0,
> +                  IOPRIO_PRIO_VALUE(ioprioClass, ioprioLevel))) {

Implement ioprio_set - don't replace it with syscall. And also ask rstrong for review.

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-1104655_v2.patch

Hi Robert, Because ioprio_set is not available in gonk-l, we need to use syscall implement it. Could you review this patch? Thanks!

Comment 10

[Kai-Zhen Li [:seinlin][:kli]]

BTW, Remove the extern one and always use local implement also work.

Comment 11

[Michael Wu [:mwu]]

(In reply to Kai-Zhen Li [:seinlin] from comment #10)
> BTW, Remove the extern one and always use local implement also work.

That's what I had in mind, but this is ok too.

Comment 12

[Kai-Zhen Li [:seinlin][:kli]]

https://hg.mozilla.org/integration/b2g-inbound/rev/692637471b98

Comment 13

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8547144 [details] [diff] [review]
bug-1104655_v2.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): porting job.
User impact if declined: update service may fail.
Testing completed: local test and land in m-c.
Risk to taking this patch (and alternatives if risky): low, add a local implementation for missing function call.
String or UUID changes made by this patch: none

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/692637471b98

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/428ef5586cf3