Stopping Marionette with Ctrl-C does not quit the application

RESOLVED FIXED in mozilla37

Status

defect
--
critical
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: whimboo, Assigned: ahal)

Tracking

({pi-marionette-runner})

Trunk
mozilla37
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

When Marionette is running tests in the target application, and you issue ctrl-c in the terminal, Marionette quits but does not close the application it has started. 

Marionette should be made failure-proof so that the application under test is always closed whatever happens to Marionette. Otherwise instances of the application will continue to exist, and can badly interact with following tests.
is this in general or e10s specific?
I don't have underlined tab names when running the tests from the firefox-greenlight repository. So the browser is not running in e10s mode, and this applies in general.
Assignee

Updated

5 years ago
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Assignee

Comment 3

5 years ago
Attachment #8532095 - Flags: review?(dburns)
Assignee

Comment 4

5 years ago
/r/1147 - Bug 1104742 - Marionette runner should cleanup marionette objects when gc'ed, r=AutomatedTester

Pull down this commit:

hg pull review -r 8a869167794d3bb439d167f4d29ceb8c820a5ebf
Attachment #8532095 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/92d3bf8747e8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Assignee

Comment 8

4 years ago
Attachment #8532095 - Attachment is obsolete: true
Attachment #8618720 - Flags: review+
You need to log in before you can comment on or make changes to this bug.