1104764 - [Rooms][Settings] Delete rooms

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Comment 1

[Oscar Patiño González]

The first part (cleaning all rooms) is completed, but I have doubts about cleaning only revoked urls. Is it the correct choice to search between revoked urls those that are rooms and then delete them? Or should I implement a revoking urls system for only rooms?

Comment 2

[Maria Angeles Oteo (:oteo)]

Please, do not work on this bug, let's wait Cristian to come back from his holidays. As I commented last week, I agreed with Jorge that this feature could be decrepaded from 1.1.1 version. 
Depending on the server bug progress (bug 1106562) we will address or not the "Clean all Rooms" part.

Comment 3

[Cristian Rodriguez (:crdlc)]

We can talk offline about this today

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 5

[Cristian Rodriguez (:crdlc)]

Borja the API is only available in development |grunt build --loopServer=development|

Comment 6

[Maria Angeles Oteo (:oteo)]

Comment on attachment 8545284 [details] [review]
Github pull request

I have tested the branch with your patch and it's working fine, just remember to change the confirmation string.

According to the WF the string would be: "Are you sure you want to clean your rooms?" (without "all")

I have already confirmed with Monica that we can delete in the "Clear all rooms" button the "(active and expired)" string as we are not going to implement the Clear all expired rooms button in this release. So it's fine that string in your implementation.

Thanks a lot!

Comment 7

[Maria Angeles Oteo (:oteo)]

Be aware that we can not land this patch until the API change (bug 1106562) is uplifted to Production in 0.15.0 version

Comment 8

[Cristian Rodriguez (:crdlc)]

Changing this right now

(In reply to Maria Angeles Oteo (:oteo) from comment #6)
> Comment on attachment 8545284 [details] [review]
> Github pull request
> 
> I have tested the branch with your patch and it's working fine, just
> remember to change the confirmation string.
> 
> According to the WF the string would be: "Are you sure you want to clean
> your rooms?" (without "all")
> 
> I have already confirmed with Monica that we can delete in the "Clear all
> rooms" button the "(active and expired)" string as we are not going to
> implement the Clear all expired rooms button in this release. So it's fine
> that string in your implementation.
> 
> Thanks a lot!

Comment 9

[Cristian Rodriguez (:crdlc)]

Finally according to MA and UX:

deleteAllRoomsConfirmation = Are you sure you want to clean all your rooms?
deleteAllRoomsConfirmation = ¿Estás seguro de que quieres eliminar todas las rooms?

just in case Borja thinks that Cristian got crazy after saying that he will remove the "all" word XD

Comment 10

[Borja Salguero [:borjasalguero]]

Comment on attachment 8545284 [details] [review]
Github pull request

Great job! Thanks!

Comment 11

[Cristian Rodriguez (:crdlc)]

Hi Maria, the patch has been reviewed and ready to be landed, so please let me know when the new API is in production please

(In reply to Maria Angeles Oteo (:oteo) from comment #7)
> Be aware that we can not land this patch until the API change (bug 1106562)
> is uplifted to Production in 0.15.0 version

Comment 12

[Maria Angeles Oteo (:oteo)]

I talked with Remy about it last Friday. He confirmed that this week the O.15.0 version will be tagged so at the beginning of next week that server version should be uplifted to Production.

We can not land our patch (bug 1104764) in Loop application until bug 1106562 is uplifted to Production Server.

Setting ni to Rémy and Alexis so they can be aware that we need this patch (bug 1106562) to be uplifted to Production for the Loop mobile version as soon as possible. Thanks a lot!

Comment 13

[Alexis Metaireau (:alexis)]

That should be the case yes!

Comment 14

[Cristian Rodriguez (:crdlc)]

master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/9bcab9a792d5a73ddaf6d921796a850baa319cf5