1104783 - deleting all permissions does not remove a user from the permissions page

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Description

[[e-mail] (:bhearsum)]

I noticed this while playing around on aus4-admin-dev - if I delete all of the permissions a user has, they continue to appear in the list of users after the modal dialog disappears. Totally minor thing.

Comment 1

[Peter Bengtsson [:peterbe]]

So, so I send something like a "DELETE /api/users/:userid" if the number of permissions is reduced down to 0? Or should it be an explicit action? E.g.:

<button ng-show="!permissions.length" ng-click="deleteUser(user)">No permission, eh? Delete user</button>

Comment 2

[[e-mail] (:bhearsum)]

I think you just need to remove the username from the list if their last permission is deleted. There's no reference to a user in Balrog except in the permissions table, which has a PK of (username, permission) - so when the last permission is deleted, the user is gone from the db.

Comment 3

[Peter Bengtsson [:peterbe]]

This was fixed in the balrog-ui repo with this: https://github.com/mozilla/balrog-ui/commit/4b5d799614729405735d98f21ab27507a950e834

Now we just need to put this into balrog.

Comment 4

[[e-mail] (:bhearsum)]

I'm hoping to do a push after we ship Firefox 34 next week to pick up this and any other pending changes.

Comment 5

[[e-mail] (:bhearsum)]

In production.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/5608f80fe8be21fef4feb525a2b47c9bcd9eb185
[balrog-ui] fixes bug 1104783 - last permission should remove user

https://github.com/mozilla/balrog/commit/b6722e1ef6e9cbeb17e0051588a63a2133b0301e
[balrog-ui] Merge pull request #3 from peterbe/bug-1104783-last-permission-should-remove-user

Bug 1104783 last permission should remove user